Re: [Module-build-general] copy_if_modified issue

[Ken W. <ke...@ma...>]

On Thursday, September 4, 2003, at 01:34  PM, gwhite wrote:

> Line 1925-27 in base.pm is:
>   my $to_path = $args{to} || File::Spec->catfile( $args{to_dir},
> $args{flatten}
> 						  ?
> File::Basename::basename($file)
> 						  : $file );
> Should be:
>   my $to_path = $args{to_dir} || File::Spec->catfile( $args{to_dir},
> $args{flatten}
> 						  ?
> File::Basename::basename($file)
> 						  : $file );
>
> the missing _dir appears to be a typo.

I think it's correct as written - it accepts either a 'to' parameter 
indicating a file, or a 'to_dir' parameter indicating a directory.  
This is analogous to the shell command 'cp':

  cp file.txt foo/file.txt  # explicit filename given
  cp file.txt foo/          # same thing with implicit filename


>
> And since to_dir is supposed to be a directory 1930-31 should change
> from:
>   # Create parent directories
>   File::Path::mkpath(File::Basename::dirname($to_path), 0, 0777);
>
> To:
>
>   # Create parent directories
>   File::Path::mkpath($to_path, 0, 0777);

$to_path is a file name, not a directory name.


> I am using the module to install a complete perl only application on 
> web
> servers (cross platform), the feature I would like to see is the 
> ability
> to have other subdirectories (off of basedir) copied where I need them
> on the web server (html, config files, templates, fonts for PDF).  It
> seems that if I could add my own install types, then set the install
> path that would do it, but maybe I am missing something.

Yeah, that should do it.

  -Ken