Re: [Module-build-general] [PATCH] always copy files to dist dir
Status: Beta
Brought to you by:
kwilliams
|
From: Dave R. <au...@ur...> - 2003-08-19 13:50:13
|
On Mon, 18 Aug 2003, Ken Williams wrote: > > On Wednesday, August 13, 2003, at 10:52 AM, Dave Rolsky wrote: > > > I proposed this earlier and got no response so here's a patch to > > implement > > this. I think doing this just makes more sense, since otherwise we > > can't > > manipular files in the dist dir without affecting the base dir files, > > since the dist dir could just be symlinks. > > This patch seems to have broken M::B's 'disttest' action, because we > don't have permission to write META.yml files. > > I'm about to do a new beta release of 0.19_05, so I'll roll back this > change for it - if you can figure out how to make it work properly > again, I'll re-patch. I agree that it's weird to make links, > especially since links aren't really a cross-platform concept. I think we just need to chmod the file in the distmeta action. -dave /*======================= House Absolute Consulting www.houseabsolute.com =======================*/ RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.173 diff -u -r1.173 Base.pm --- lib/Module/Build/Base.pm 18 Aug 2003 16:02:24 -0000 1.173 +++ lib/Module/Build/Base.pm 19 Aug 2003 13:47:57 -0000 @@ -1507,7 +1507,7 @@ my $dist_dir = $self->dist_dir; $self->delete_filetree($dist_dir); $self->add_to_cleanup($dist_dir); - ExtUtils::Manifest::manicopy($dist_files, $dist_dir, 'best'); + ExtUtils::Manifest::manicopy($dist_files, $dist_dir, 'cp'); warn "*** Did you forget to add $self->{metafile} to the MANIFEST?\n" unless exists $dist_files->{$self->{metafile}}; $self->_sign_dir($dist_dir) if $self->{properties}{sign}; @@ -1595,6 +1595,9 @@ }; $node->{generated_by} = "Module::Build version " . Module::Build->VERSION; + + chmod 0644, $self->{metafile} + or die "Cannot make $self->{metafile} writeable: $!"; # YAML API changed after version 0.30 my $yaml_sub = $YAML::VERSION le '0.30' ? \&YAML::StoreFile : \&YAML::DumpFile; |