[Module-build-general] Re: [PATCH] non-numeric $VERSION comparison error

[Ken W. <ke...@ma...>]

On Thursday, July 31, 2003, at 07:13  PM, Steve Purkis wrote:

> On Thursday, July 31, 2003, at 07:32  pm, Steve Purkis wrote:
>
>> I suppose it's worth asking this: why not use version objects?
>
> Because they don't come standard with most (any?) versions of perl is 
> one reason.


Right, you beat me to the answer. =)

>> Which works for most things.  I think it break because of how perl 
>> does SV -> NV conversions [1]:
>>
>> 	'0.03_01' > '0.03' == false
>
> The attached patch fixes this.  It doesn't do everything that 
> version.pm does, but I imagine it can be integrated easily if need be.

Yup - my sense is that we won't actually depend on version.pm unless we 
really need to, but that it won't be too hard to get the 
compare_versions() method to do pretty much everything we need it to.

Thanks for the patch, I've applied it.

  -Ken