Re: [Module-build-general] Hello and manifypods

[Steve P. <sp...@ep...>]

On Monday, July 14, 2003, at 10:15  pm, Dave Rolsky wrote:

> On Mon, 14 Jul 2003, Steve Purkis wrote:
>
>> I've got a wee bit of experience with MakeMaker's manifypods target,
>> and seeing as the manifypods Action isn't implemented yet and it's
>> something I need before I can switch over, I decided to have a go at
>> it.  Hope I'm not stepping on anyone's toes...
>
> I was thinking of doing it, but I didn't really want to, so I'm happy 
> to
> see your patch.

Good-o..  I'm happy to be able to help :).


>> I got as far as generating MAN3 pods - no installation or MAN1 pods
>> yet, but it's getting late and I thought now might be a good time to
>> stop and get some feedback.  So I've attached a patch, comments are
>> welcome.  Will prolly finish it off later this week if people like the
>> look of it..
>
> A couple things:
>
> - This should be part of Module::Build::Base, not a separate file

Yeah, it will do - I just find it easier to write tests & code together 
sometimes..  keeps me focused, & can be quicker.  Once I think its done 
I move it where it belongs & see if it breaks anything else.


> - Section 1 pods should be generated based on the files found by
> $self->find_script_files, I think.

If not, it'll do as a starting point.  Is there a chance modules will 
have Pod in .xs or .c files, binaries, or maybe something like 
bin/foo.pod  ?


> - Section 3 pods should be generated based on $self->find_pod_files, 
> and
> $self->find_pm_files.  These are higher level than running ->rscan_dir 
> and
> allow the module maintainer to specify which files to process.  If you
> just run rscan_dir yourself you'd be ignoring that.

Good point - I'll switch that over.


> - In the manpage_name method, you can call File::Spec->canonpath on the
> $file var before calling splitdir, and that should remove doubled
> directory separators and other cruft.

Another good point; will roll that in.


> Otherwise it looks good.  For the install bits, I think it's as simple 
> as
> the patch below my sig.

A one-liner... is that really it?  Well, I'm glad I stopped when I did 
otherwise I would've sat for hours trying to suss that out ;-).

I'll roll all this together into a proper patch over the next few days.

Ta for the comments,
-Steve