Re: [Module-build-general] Hello and manifypods

[Dave R. <au...@ur...>]

On Mon, 14 Jul 2003, Steve Purkis wrote:

> I've got a wee bit of experience with MakeMaker's manifypods target,
> and seeing as the manifypods Action isn't implemented yet and it's
> something I need before I can switch over, I decided to have a go at
> it.  Hope I'm not stepping on anyone's toes...

I was thinking of doing it, but I didn't really want to, so I'm happy to
see your patch.

> I got as far as generating MAN3 pods - no installation or MAN1 pods
> yet, but it's getting late and I thought now might be a good time to
> stop and get some feedback.  So I've attached a patch, comments are
> welcome.  Will prolly finish it off later this week if people like the
> look of it..

A couple things:

- This should be part of Module::Build::Base, not a separate file

- Section 1 pods should be generated based on the files found by
$self->find_script_files, I think.

- Section 3 pods should be generated based on $self->find_pod_files, and
$self->find_pm_files.  These are higher level than running ->rscan_dir and
allow the module maintainer to specify which files to process.  If you
just run rscan_dir yourself you'd be ignoring that.

- In the manpage_name method, you can call File::Spec->canonpath on the
$file var before calling splitdir, and that should remove doubled
directory separators and other cruft.


Otherwise it looks good.  For the install bits, I think it's as simple as
the patch below my sig.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

--- Base.pm.~1.139.~	2003-07-07 12:52:48.000000000 -0500
+++ Base.pm	2003-07-14 16:16:47.000000000 -0500
@@ -56,7 +56,7 @@
 				   build_requires => {},
 				   conflicts => {},
 				   perl => $perl,
-				   install_types => [qw(lib arch script)],
+				   install_types => [qw(lib arch script man1 man3)],
 				   installdirs => 'site',
 				   include_dirs => [],
 				   %input,