Re: [Module-build-general] Win32 bug fixed?

[Ken W. <ke...@ma...>]

On Tuesday, July 8, 2003, at 09:07  PM, Randy W. Sims wrote:
>
> All clear...

Great, thanks for testing it.

> BTW, the annoying output from make can be eleminated with the 
> '-nologo' switch to nmake (if $Config{make} eq 'nmake').

Okay, I'll apply the patch below.

  -Ken

==========================================================
--- t/compat.t  10 Jun 2003 15:43:41 -0000      1.4
+++ t/compat.t  9 Jul 2003 15:53:51 -0000
@@ -10,6 +10,7 @@
  plan tests => 23;
  ok(1);  # Loaded

+my @make = $Config{make} eq 'nmake' ? ('nmake', '-nologo') : 
($Config{make});

  my $goto = File::Spec->catdir( Module::Build->cwd, 't', 'Sample' );
  chdir $goto or die "can't chdir to $goto: $!";
@@ -29,17 +30,17 @@
    ok $result;
    ok -e 'Makefile', 1, "Makefile exists";

-  ok $build->do_system($Config{make});
+  ok $build->do_system(@make);

    # Can't let 'test' STDOUT go to our STDOUT, or it'll confuse 
Test::Harness.
    my $success;
    my $output = stdout_of( sub {
-                           $success = $build->do_system($Config{make}, 
'test');
+                           $success = $build->do_system(@make, 'test');
                           } );
    ok $success;
    ok uc $output, qr{DONE\.|SUCCESS};

-  ok $build->do_system($Config{make}, 'realclean');
+  ok $build->do_system(@make, 'realclean');
    $build->dispatch('realclean');
    ok not -e 'Makefile.PL';
  }
==========================================================