Re: [Module-build-general] signature verification and some bug fixes
Status: Beta
Brought to you by:
kwilliams
|
From: Dave R. <au...@ur...> - 2003-07-03 19:27:37
|
On Thu, 3 Jul 2003, Ken Williams wrote: > > On Thu, 3 Jul 2003, Ken Williams wrote: > > > >>> 3. Adds a verify action which verifies a signature. > >> > >> Why does this patch (excerpt below) verify in $self->dist_dir? Seems > >> like we'd want to verify in the main directory, $self->base_dir. > > > > Hmm, that's a good question. For the module _author_, verifying > > should be > > done in the dist dir, because that's what contains _exactly_ what will > > be > > in the final distro. > > Probably this should just be done automatically after signing, to make > sure that the signature just created is actually valid. Or one could > just assume it's valid. > > > > For the installer, verify should be run in the > > base_dir, I guess. Except, I bet it'll fail because of the presence of > > the "Build" script. > > Extra files will make it fail? Oops, I was wrong. It respects your MANIFEST.SKIP file. But that _would_ need to be included in the released distro, which is probably worth noting somewhere in the docs. -dave /*======================= House Absolute Consulting www.houseabsolute.com =======================*/ |