Re: [Module-build-general] bug in Module-Build-0.18

[jk <bil...@fa...>]

Ken Williams wrote:

>
> On Thursday, May 15, 2003, at 09:39  PM, jk wrote:
>
>> Ken Williams wrote:
>>
>>>
>>> Hmmm - care to try another patch?  I think maybe it's the way I'm 
>>> overwriting $ENV{PERL5LIB} in the tests.  Patch below.
>>
>>
>> Sorry for my ignorance, but I don't know how to a patch, I have never 
>> done that before... if you can explain I'll be happy to try if it 
>> might help.
>
>
> Hi JK,
>
> No need to be sorry - there was a time when each of us didn't know how 
> to patch. =)
>
> For a short patch like this, you can just apply it by hand by editing 
> the files it indicates.  Each hunk of the patch gives a little context 
> (line numbers are in the header too), then shows lines that should be 
> removed by putting '-' in front of them, and lines that should be 
> added by putting '+' in front of them.  So you can just make those 
> edits yourself if you want.
>
> If you want to apply a patch automatically, save it in a file called 
> "patch.txt" (or whatever you want), then from the top level of the 
> Module-Build directory issue the command "patch < patch.txt".  More 
> details are in the manual page for the 'patch' command.
>
>  -Ken
>
>
Hi Ken,

Sorry it took so long to do this, been busy.  I patched the basic.t and 
runthrough.t files from a freshly untarred Module-Build-0.18 as 
instructed, so they look like this:

=====from t/basic.t=====
# So 'test' and 'disttest' in Sample/ can see the not-yet-installed 
Module::Build.
{
  my $build_dir = File::Spec->catdir( Module::Build->cwd, 'blib', 'lib' );
  unshift @INC, $build_dir;
  $ENV{PERL5LIB} = $ENV{PERL5LIB} ? "$build_dir:$ENV{PERL5LIB}" : 
$build_dir;
}

chdir 't';
===end t/basic.t====

===from t/runthrough.t===
# So 'test' and 'disttest' can see the not-yet-installed Module::Build.
{
  my $build_dir = File::Spec->catdir( $start_dir, 'blib', 'lib' );
  unshift @INC, $build_dir;
  $ENV{PERL5LIB} = $ENV{PERL5LIB} ? "$build_dir:$ENV{PERL5LIB}" : 
$build_dir;
}
warn "PERL5LIB is $ENV{PERL5LIB}\n";

my $goto = File::Spec->catdir( Module::Build->cwd, 't', 'Sample' );
===end t/runthrough.t===


Then I did the usual install proceedure:
 perl Build.PL config=sitelib=/home/me/data/perl58/
 ./Build
 ./Build test
 ./Build fakeinstall     (to check what it'll do in 'install')
 ./Build install


There were some errors durring the tests.  They are different than the 
errors I was getting before.  The module does seem to get installed at 
the end despite the error messages.

Including the screen output below: