Re: [Module-build-general] [PATCH] ./Build ppd codebase=...

[Dave R. <au...@ur...>]

On Sat, 10 May 2003, Ken Williams wrote:

>
> On Friday, May 9, 2003, at 05:54  PM, Dave Rolsky wrote:
>
> > On Fri, 9 May 2003, Ken Williams wrote:
> >
> >> I've committed this with a bunch of changes.  I put most of the code
> >> into a new Module::Build::PPMMaker module.
> >
> > No, actually you put it in a file called PPD.pm, so it can't find it ;)
>
> Erm, I really did mean to do PPMMaker, but didn't commit the name
> change.  Try again now (also a couple other bugs fixed, I think).

I think it gets too much stuff when looking for the author (try it on
Module::Build to see).  A patch to reduce this is below.


/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

--- Base.pm.~1.116.~	2003-05-10 13:03:57.000000000 -0500
+++ Base.pm	2003-05-10 13:10:24.000000000 -0500
@@ -290,11 +290,12 @@
   my @author;
   while (<$fh>) {
     next unless /^=head1\s+AUTHOR/ ... /^=/;
-    push @author, $_;
+    push @author, $_ if /\S/ && ! /^=/;
+    last if @author && /\n|\r/;
   }
   return unless @author;

-  my $author = join '', @author[1..$#author-1];
+  my $author = join '', @author;
   $author =~ s/^\s+|\s+$//g;
   return $p->{dist_author} = $author;
 }