Re: [Module-build-general] [PATCH] ./Build ppd codebase=...

[Dave R. <au...@ur...>]

On Fri, 9 May 2003, Ken Williams wrote:

> I've committed this with a bunch of changes.  I put most of the code
> into a new Module::Build::PPMMaker module.

No, actually you put it in a file called PPD.pm, so it can't find it ;)

> Care to try it out?

Patch after sig ;)


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

Index: lib/Module/Build/Base.pm
===================================================================
RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v
retrieving revision 1.116
diff -u -r1.116 Base.pm
--- lib/Module/Build/Base.pm	9 May 2003 22:28:53 -0000	1.116
+++ lib/Module/Build/Base.pm	9 May 2003 22:54:29 -0000
@@ -1104,8 +1104,8 @@

 sub ACTION_ppd {
   my ($self) = @_;
-  require Module::Build::PPMMaker;
-  my $ppd = Module::Build::PPMMaker->new(archname => $self->{config}{archname});
+  require Module::Build::PPD;
+  my $ppd = Module::Build::PPD->new(archname => $self->{config}{archname});
   my $file = $ppd->make_ppd(%{$self->{args}}, build => $self);
   $self->add_to_cleanup($file);
 }
Index: lib/Module/Build/PPD.pm
===================================================================
RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/PPD.pm,v
retrieving revision 1.1
diff -u -r1.1 PPD.pm
--- lib/Module/Build/PPD.pm	9 May 2003 21:17:40 -0000	1.1
+++ lib/Module/Build/PPD.pm	9 May 2003 22:54:30 -0000
@@ -1,4 +1,4 @@
-package Module::Build::PPMMaker;
+package Module::Build::PPD;

 use strict;

@@ -74,7 +74,7 @@
   # unfortunately, seems to indicate that a module works with _only_
   # that version of Perl, and so is only appropriate when a module
   # uses XS.
-  if (keys %{$self->find_xs_files}) {
+  if (keys %{$build->find_xs_files}) {
     my $perl_version = $self->_ppd_version($build->perl_version);
     $ppd .= sprintf(<<'EOF', $perl_version, $^O, $self->{archname});
         <PERLCORE VERSION="%s" />
@@ -144,7 +144,7 @@

 =head1 NAME

-Module::Build::PPMMaker - Perl Package Manager file creation
+Module::Build::PPD - Perl Package Manager file creation

 =head1 SYNOPSIS

Index: t/xs.t
===================================================================
RCS file: /cvsroot/module-build/Module-Build/t/xs.t,v
retrieving revision 1.7
diff -u -r1.7 xs.t
--- t/xs.t	9 May 2003 22:29:13 -0000	1.7
+++ t/xs.t	9 May 2003 22:54:30 -0000
@@ -41,7 +41,7 @@

   my $ppd = slurp('XSTest.ppd');

-  my $perl_version = Module::Build::PPMMaker->_ppd_version($m->perl_version);
+  my $perl_version = Module::Build::PPD->_ppd_version($m->perl_version);

   # This test is quite a hack since with XML you don't really want to
   # do a strict string comparison, but absent an XML parser it's the