Re: [Module-build-general] Tests on perl 5.005

[Ken W. <ke...@ma...>]

On Friday, May 9, 2003, at 01:53  PM, Dave Rolsky wrote:

> On Fri, 9 May 2003, Ken Williams wrote:
>
>> Does someone have a perl 5.005 that they could test the current
>> Module::Build from CVS on?  I'd like to close bug 2302 at
>> http://rt.cpan.org/Ticket/Display.html?id=2302 .
>
> I do, but the current CVS is quite broken.

Oops, I'd meant to back out a change I accidentally committed before.  
Here's a patch:

=========================================
--- lib/Module/Build/Base.pm    8 May 2003 14:22:24 -0000       1.110
+++ lib/Module/Build/Base.pm    9 May 2003 18:58:49 -0000
@@ -614,10 +614,9 @@

  sub dispatch {
    my $self = shift;
-  local $self->{action} = shift;

    if (@_) {
-    my %p = @_;
+    ($self->{action}, my %p) = @_;
      my $args = $p{args} ? delete($p{args}) : {};

      $self->{args} = {%{$self->{args}}, %$args};
=========================================

I've committed this now.

What's it look like with this & 5.005 now?


  -Ken