Re: [Module-build-general] [PATCH] - really fix add_to_cleanup
Status: Beta
Brought to you by:
kwilliams
|
From: Dave R. <au...@ur...> - 2003-04-24 18:58:38
|
On Thu, 24 Apr 2003, Ken Williams wrote: > I don't much like the idea of the tests reading the 'cleanup' file - > first because that should basically be considered private data, not > part of the interface, and second because the caller shouldn't really > care whether it's on disk or not, just whether it "works right". > > The current design is that the list of cleanup files is written to disk > at the soonest possible moment, which means whenever add_to_cleanup() > is called and there's a config directory to write into. Maybe we > should try to do it even sooner, i.e. whenever add_to_cleanup() *or* > create_build_script() is called. > > The patch I'll apply is appended here. It uses some new interface > stuff that I think is useful. It also changes the add_to_cleanup() > method yet again, this time for the simpler. I think the whole system > is a bit simpler now, actually. Simpler is good. -dave |