Re: [Module-build-general] ExtUtils::ParseXS & 5.00503

[Ken W. <ke...@ma...>]

On Sunday, March 30, 2003, at 12:03  AM, Dave Rolsky wrote:

> On Sat, 29 Mar 2003, Ken Williams wrote:
>
>> That test should pass (not be skipped) even if EU::ParseXS isn't
>> around.  You're seeing it fail?  This is t/xs.t in Module::Build, 
>> right?
>
> I was a little confused.  If EU::ParseXS _is_ installed and you try to
> load it with Perl 5.00503, it does actually load (I thought it was
> dying), but it doesn't work right.  So here's a test patch that skips
> the tests unconditionally if you're using a Perl before 5.6.0.

Since when are we in the practice of skipping a test when we discover 
it doesn't work! =)  It needs to be fixed, not skipped.  If it remains 
broken, then M::B is broken on that platform for compiling XS modules.

If ExtUtils::ParseXS doesn't work on 5.005, then you probably shouldn't 
have installed it in a location shared with 5.005.  But I'm sort of 
glad you did, because probably other people will too, and we shouldn't 
be loading a module that doesn't work.

How about this patch instead of yours:

  -Ken

Index: lib/Module/Build/Base.pm
===================================================================
RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v
retrieving revision 1.80
diff -u -r1.80 Base.pm
--- lib/Module/Build/Base.pm	30 Mar 2003 06:06:16 -0000	1.80
+++ lib/Module/Build/Base.pm	30 Mar 2003 15:42:16 -0000
@@ -1184,7 +1184,8 @@

    print "$file -> $file_base.c\n";

-  if (eval {require ExtUtils::ParseXS; 1}) {
+  # ExtUtils::ParseXS requires 5.6, but it's in @INC sometimes anyway.
+  if ($] >= 5.006 and eval {require ExtUtils::ParseXS; 1}) {

      ExtUtils::ParseXS::process_file(
  				    filename => $file,

===================================================================