Re: [Module-build-general] [PATCH] MSWin32 override make_executable() to call pl2bat utility.
Status: Beta
Brought to you by:
kwilliams
|
From: Randy W. S. <Ra...@Th...> - 2003-03-12 03:28:32
|
On 3/11/2003 11:31 AM, Ken Williams wrote:
> Thanks - I've applied it, finally.
>
> The make_executable() routine is called for any script requiring
> execution privileges, does it make sense to always create a .bat file,
> even for things like the Build script?
>
> -Ken
It makes sense to call it on any script that will be installed on the
users system in as much as this was the behaviour under MakeMaker. It
does explicitly skip the Build script, or rather, anything named in
$self->{properties}{build_script}.
IME, it's really not needed at all except where the script is expected
to handle redirection at the commandline. It may make more sense to use
pl2bat as an optional filter to be run only when the module author
explicitly asks for it. However, it seemed safest to follow the
convention established by MakeMaker, running pl2bat on all scripts that
are to be installed.
Randy.
|