[Module-build-general] "0" options in compilation lines?

[Ken W. <ke...@ma...>]

Hi Randy,

I noticed this line in the format_compiler_cmd() code from your patch:

   return [ grep {defined && $_} (
     $spec{cc}, '-c'         ,
     @{$spec{includes}}      ,
     @{$spec{cflags}}        ,
     @{$spec{optimize}}      ,
     @{$spec{defines}}       ,
     @{$spec{perlinc}}       ,
     "-Fo$spec{output}"      ,
     $spec{source}           ,
   ) ];

I was wondering about the check for boolean truth, which will turn 
argument lists like ('-foo', 0) into ('-foo').  Maybe it would be safer 
to just use grep {defined()}, or grep {defined() && length()}, or 
something?  Or are there some zeroes you're specifically trying to 
filter out?

  -Ken