Re: [Module-build-general] distsign & sign option

[Ken W. <ke...@ma...>]

On Saturday, February 8, 2003, at 04:13  PM, Dave Rolsky wrote:

> At the end of this message is a patch that implements a distsign action
> for Module::Build.  This uses Module::Signature to sign the 
> distribution.
> Additionally, it adds a new property, 'sign', which can be set for a
> distribution.  If true, the distsign action is called whenever dist is
> called.
>
> There are tests as well, but is should be noted that there are two
> potential problems with the test:
>
> 1. If you have Module::Signature, but no keys in your keyring, the 
> tests
> will probably fail.
>
> 2. If you do have keys, you'll be prompted for a passphrase.  I'm not 
> sure
> if this is really desirable behavior for tests run during a module
> install.
>
> Anyway, disabling the tests for non-maintainers would be easy enough.


I've applied these patches to CVS.  There are a couple of problems 
still - when I run the tests, I get these errors:


[junior:~/src/Module-Build] ken% Build test test_files=t/runthrough.t
t/runthrough........ok 10/13Not in MANIFEST: Build
Not in MANIFEST: Sample-0.01/Build.PL
Not in MANIFEST: Sample-0.01/MANIFEST
Not in MANIFEST: Sample-0.01/META.yml
Not in MANIFEST: Sample-0.01/lib/Sample.pm
Not in MANIFEST: Sample-0.01/test.pl
Not in MANIFEST: _build/build_params
Not in MANIFEST: _build/cleanup
Not in MANIFEST: _build/prereqs
Not in MANIFEST: save_out
==> MISMATCHED content between MANIFEST and the distribution! <==
==> Please correct your MANIFEST file and/or delete extra files. <==


It looks like Module::Signature (version 0.21) is trying to sign in the 
top-level module directory instead of in the distdir directory.  Do you 
see different behavior?

After those errors, I get some errors about not having my keyring set 
up properly, which I don't.  It would be nice if Module::Signature had 
some methods to probe for this kind of thing, then we could do such 
probing in the tests.



  -Ken