[Module-build-general] Re: Module-Build CVS on Cygwin98
Status: Beta
Brought to you by:
kwilliams
|
From: Ken W. <ke...@ma...> - 2002-11-21 01:12:11
|
On Thursday, November 21, 2002, at 11:55 AM, Michael G Schwern wrote:
>
> Why do you even keep $self->{cleanup_fh} around and open? Its
> only used
> immediately after its set in add_to_cleanup(). It seems the
> only use is to
> determine if you've already appended to the cleanup file, so
> maybe it can be
> replaced with a boolean?
add_to_cleanup() may be called multiple times, and it seemed
wasteful to do a bunch of opening & closing. I suppose I could
open & close it every time add_to_cleanup() is called, but I'm
not sure there's a very compelling reason to do that.
-Ken
|