Re: [Module::Build] broken META.yml file
Status: Beta
Brought to you by:
kwilliams
From: Randy W. S. <ml...@th...> - 2006-05-16 19:58:13
|
Eric Wilhelm wrote: > # from Stephen Adkins > # on Tuesday 16 May 2006 05:55 am: > > >>1. The Gantry distribution does "author" wrong > > >>I don't know if somewhere else in Module::Build needs to do something >>different in scanning Gantry.pm (to get the desired arrayref), but >>Module::Build::YAML is behaving correctly (and creating the same >>result as YAML.pm). > > > =head1 AUTHOR > > Foo <fo...@ba...> > > Bar <ba...@ba...> > > =cut > > ...is two paragraphs (renders on separate lines in perldoc) > > =head1 AUTHOR > > Foo <fo...@ba...> > Bar <ba...@ba...> > > =cut > > ...is one paragraph > > =head1 AUTHOR > > Foo <fo...@ba...> > Bar <ba...@ba...> > > =cut > > ...is one literal paragraph of two lines > > =head1 AUTHOR > > Foo <foo at bar dot com> > > =cut > > ... is ignored without my patch, which was ignored. Not ignored; just not applied. ;) I saw the discussion, but kept quiet because I have a stong bias against obfuscation: I stubbornly refuse to give ground to spammers-I was here first. Besides, obfuscated addresses are as easy to detect and de-obfuscate as a normal address, and there are several ways to obfuscate email where your patch only detects one particular method. > But it looks like the behavior WRT lines/paragraphs/literals may depend > on whether Pod::Parser is installed as textblock() is fed a paragraph > while the M::B::PodParser::_myparse_from_filehandle() is going > line-by-line. > > From the looks of things, the first three cases should turn into > something like this (where $f = "Foo ..." and $b = "Bar ...".) > > 1. > M::B::PP [$f, $b] > P::P [$f, $b] > > 2. > M::B::PP [$f, $b] > P::P ["$f $b"] > > 3. > M::B::PP [" $f", " $b"] > P::P [" $f\n $b"] > > The automated test is not trivial, but is still left as an exercise for > the reader. Maybe we should just complain and ask the user to specify the 'dist_author' argument to the constructor if we detect multiple lines? Or we could require format (2) above in the AUTHOR section where there is one address perl line; we should be able to detect that reliably enough. Randy. |