[Module::Build] Re: Module::Build failures in the Perl core since upgrade to Module::Build 0.28

[Randy W. S. <ml...@th...>]

Steve Peters wrote:
> On Thu, May 04, 2006 at 05:54:57PM -0400, Randy W. Sims wrote:
> 
>>Steve Peters wrote:
>>
>>>>Change 28045 by stevep@stevep-kirk on 2006/05/02 02:47:43
>>>>
>>>>	Escape prompts with #'s to avoid causing tests to fail from
>>>>	the unexpected output.
>>>>
>>>
>>>Since the above change there's been no change in the results, and, for 
>>>me at least, no change in my inability to replicate this problem.  
>>>Interestingly enough, this error didn't occur with my Linux icc smoke.
>>>
>>>Is anyone else able to replicate this problem at all?
>>
>>Sorry, I've been away from my email for the last couple of days, and I 
>>haven't been watching the smokes. I'll try to take a look at this 
>>tonight and see if I can reproduce it on any of my other systems (I 
>>didn't see it when testing on Ubuntu linux).
>>
> 
> 
> I just figured out the problem a few moments ago and have committed the 
> fix to bleadperl.  The problem was that the test depended on STDIN 
> input, but when running a smoke through cron, STDIN is closed.  The 
> change skips the failing tests if "fileno(STDIN)" returns undef.
> 
> Can you all please apply this patch back to Module::Build?

Thanks for tracking this down. I don't think it would have occured to me 
that it was only failing when running under cron where STDIN is closed.

I took a slightly different approach to fixing it which will allow the 
tests to be run even if STDIN is closed rather than skipping them. I'll 
post a patch to sync when we make the next point release.

Randy.