Re: [Module::Build] Preserving files' executable bits, once more
Status: Beta
Brought to you by:
kwilliams
From: Randy W. S. <ml...@th...> - 2006-04-11 08:38:26
|
Ken Williams wrote: > > On Apr 10, 2006, at 2:04 AM, Randy W. Sims wrote: > >> Ken Williams wrote: >> >>> On Apr 8, 2006, at 11:17 PM, Randy W. Sims wrote: >>> >>>> >>>> Borrowing code from ExtUtils::Install::install() and ::pm_to_blib >>>> (), the copy_if_modified() method now preserves file mode and >>>> timestamps. >>> >>> Sounds good to preserve mode, but I'm not sure we want to preserve >>> timestamps. Seems like the timestamp can be a useful indicator of >>> when a file got updated. >> >> >> Hmm, I hadn't really thought too much about it. I was copying the >> behavior of MakeMaker via ExtUtils::Install, basically copying the >> code verbatim from there. I'm not sure too many people would argue it >> either way though. > > > Ordinarily I'd defer to the old EU::I behavior too, but it doesn't make > much sense to me in this case. If you preserve the timestamp > blib->install, you get an essentially meaningless timestamp. If you > also preserve lib->blib then you get a potentially dangerous timestamp, > where you could replace files with things that look older. Ok. I've reverted to only preserving the executable bit of the mode. Randy |