[Module::Build] Re: [Module-build-checkins] [svn:Module-Build] r5869 - Module-Build/trunk/t

[Ken W. <ke...@ma...>]

I'm not sure about this one - it seems weird to set the path with  
Unix-like syntax but get the result in local syntax.

Can we take a little pause to review the APIs for this family of  
methods?  I think there's also some inconsistency between  
install_base_* and prefix_*, from back when I was a little confused  
about them.

  -Ken


On Apr 6, 2006, at 10:31 PM, ra...@cv... wrote:

> Author: randys
> Date: Thu Apr  6 20:31:02 2006
> New Revision: 5869
>
> Modified:
>    Module-Build/trunk/t/destinations.t
>
> Log:
> Fixup some cross-platform paths.
>
> Modified: Module-Build/trunk/t/destinations.t
> ====================================================================== 
> ========
> --- Module-Build/trunk/t/destinations.t	(original)
> +++ Module-Build/trunk/t/destinations.t	Thu Apr  6 20:31:02 2006
> @@ -92,10 +92,10 @@
>      like( $@, qr/Value must be a relative path/, '  emits error if  
> path not relative' );
>
>      $path = $mb->install_base_relpaths('elem' => 'foo/bar');
> -    is( $path, 'foo/bar', '  returns assigned path' );
> +    is( $path, catdir(qw(foo bar)), '  returns assigned path' );
>
>      $path = $mb->install_base_relpaths('elem');
> -    is( $path, 'foo/bar', '  can read stored path' );
> +    is( $path, catdir(qw(foo/bar)), '  can read stored path' );
>
>      $map = $mb->install_base_relpaths();
>      is_deeply( $map->{elem}, [qw(foo bar)], '  can access map' );
> @@ -121,10 +121,10 @@
>      like( $@, qr/Value must be a relative path/, '  emits error if  
> path not relative' );
>
>      $path = $mb->prefix_relpaths('site', 'elem' => 'foo/bar');
> -    is( $path, 'foo/bar', '  returns assigned path' );
> +    is( $path, catdir(qw(foo bar)), '  returns assigned path' );
>
>      $path = $mb->prefix_relpaths('site', 'elem');
> -    is( $path, 'foo/bar', '  can read stored path' );
> +    is( $path, catdir(qw(foo bar)), '  can read stored path' );
>
>      $map = $mb->prefix_relpaths();
>      is_deeply( $map->{elem}, [qw(foo bar)], '  can access map' );
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting  
> language
> that extends applications into web and mobile media. Attend the  
> live webcast
> and join the prime developer group breaking into this new coding  
> territory!
> http://sel.as-us.falkag.net/sel? 
> cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> Module-build-checkins mailing list
> Mod...@li...
> https://lists.sourceforge.net/lists/listinfo/module-build-checkins