Re: [Module::Build] Making 0.28 a reality

[John P. <jpe...@ro...>]

Stephen Adkins wrote:
> I have modified a version of Module::Build::Base from Module-Build-0.2611
> to add YAML support sufficient to do everything that Module::Build needs.

Excellent!

> 
> In essence, I have replaced write_minimal_metadata() with write_metadata().
> This new write_metadata() method does everything that is needed to
> write META.yml
> but it does it without YAML.pm.  Thus, we could remove all dependency on YAML.pm
> completely. (Or, we merely use the internal routine if the external YAML.pm does
> not exist.)

I'm not Ken (nor do I play him on TV), but I'd actually suggest moving 
the code to a new module Module::Build::YAML, both for clarity (to 
separate the code for easier maintenance) as well as easier replacement 
(M::B can try to use YAML and only if it isn't found switch to using 
M::B::YAML instead).  It may be that at some time in the future it would 
be useful to be able to /read/ YAML data (which requires the full YAML 
distro) instead of just /writing/ YAML (which the compatibility layer 
can handle nicely).

> 
>  1. How exactly should I submit this? 

Check out a new working copy from CVS, then copy your changes in place 
and then run, e.g.

	$ cvs diff -u > yaml.diff

If you do as I suggested above and separate the code into a new module, 
you will need to do a

	$ cvs add lib/Module/Build/YAML.pm

before the above, so that you get the new file added too.

HTH

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748