Re: [Module::Build] Re: [PATCH] add Module::Build 0.27_08

[Randy W. S. <ml...@th...>]

Randy W. Sims wrote:
> Randy W. Sims wrote:
> 
>> Unfortunately, I don't have a broken system to test on so I'm mostly 
>> guessing. I do have an old 633 Mhz Pentium PC laying around somewhere 
>> that I can install one of the BSD variant on tonight or tomorrow.
> 
> I've been taking my time getting my BSD test system up because I was 
> assuming from previous reports that the BSD issue was mostly fixed. I 
> finally got it up and configured enough to do some testing, and it looks 
> like there are still failures because of the same issue, mostly.
> 
> The attached patch is my rough working code to get it fixed.
> 
> Module::Build::Base::_perl_is_same needs to set @INC in order to find 
> Config.pm when $ENV{PERL_CORE}. Is there a better alternative?
> 
> ExtUtils::CBuilder::Base::perl_src needs to check in the current 
> directory before moving up. Well, maybe. This really is just a result of 
> the way I rewrote Module::Build::Base::find_perl_interpreter to collect 
> a list of /all/ candidates before testing for the correct one. If $perl 
> and $abs_perl where tested and successful, we could return before the 
> call to perl_src(). It's not really a problem except for the spurious 
> warning about not find the perl source.
> 
> This is tested on FreeBSD 6.0 & Ubuntu Linux. I'll test later on Windows 
> & Cygwin.

Ok. With this patch I get no errors, warnings, or any noise on the above 
mentioned four platforms.

Any comments on the implementation? The only iffy part from my point of 
view is the _perl_is_same method. Is it the best way to handle this?

One other minor change I'd like to make that'd not in the patch is to 
change ExtUtils::CBuilder::perl_src to not emit a warning, leaving it up 
to the caller to emit a warning if needed.

Other that that, I think the basics are all correct for most platforms.

Randy.