Re: [Module::Build] Re: [PATCH] add Module::Build 0.27_08

[Yitzchak Scott-T. <sth...@ef...>]

On Tue, Mar 07, 2006 at 05:36:30PM -0600, Ken Williams wrote:
> 
> On Mar 7, 2006, at 2:24 PM, Yitzchak Scott-Thoennes wrote:
> 
> >
> >I think just putting code conditional on $ENV{PERL_CORE} in
> >find_perl_interpreter is good enough; no need to modify the tests.
> 
> If possible, I'd like to avoid that.  The fewer conditionals we have  
> on PERL_CORE the better - they make me nervous because I never really  
> understand them and I never know if I'm breaking something on blead.

Maybe I'll try to go through and add some comments at some point.
 
> Also, if we can get this bit working without special-casing, it would  
> probably solve the issue for other people too.

Let me mention how a few minutes browsing of the code makes me think
makemaker does things.  First, PERL_CORE and PERL_SRC are properties
that can be provided as parameters to Makefile.PL.  PERL_CORE defaults
to $ENV{PERL_CORE} or to 0 if that isn't set.  PERL_SRC is the
toplevel directory of the perl sources and is required if PERL_CORE is
set; if it isn't set manually, it will be searched for in .., ../..,
etc.  (5 levels max).

I'm not sure how this translates into how Module::Build could work,
especially since some of the things makemaker does differently based
on PERL_CORE have been split off MB into CBuilder.  But for now, I
think checking $ENV{PERL_CORE} in Base.pm is more of a step forward
than backward.