Re: [Module::Build] ./Build on Win98

[Randy W. S. <ml...@th...>]

Ken Williams wrote:
> 
> On Mar 1, 2006, at 5:17 PM, Randy W. Sims wrote:
> 
>> All the solutions I can think of, and the one you mention above are  
>> all variations on a theme. None of them are ideal, so I have no  
>> outstanding preference. Options are:
>>
>> 1) Rearrange the command to put the unquotable(?) construct at the  
>> end of the command line. Subject to fail later when code is  modified 
>> and inadvertently changes order.
>>
>> 2) Stuff @ARGV and do 'pl2bat.bat' as you suggest. Makes me  nervous; 
>> kinda depends on knowing pl2bat internals are safe to  C<do>. Also, 
>> more hoops because we have to tie stdin & stdout in  place of 
>> redirection.
>>
>> 3) Wrap pl2bat in a module and publish it.
>>
>> 4) Copy the code from pl2bat[1] directly into M::B::P::Windows;  It's 
>> short, and can be abbreviated somewhat for our purpose, but it  still 
>> duplicates code.
>>
>> I probably like (1) the least, and I guess I lean more towards (3)  or 
>> (4)
> 
> 
> #3 is certainly The High Road, but it introduces a platform-specific  
> dependency, and would break from our current rule of no required  
> dependencies past what's in perl 5.6.  Other than that there's  probably 
> no downside.
> 
> #4 is probably the easiest to do in the short term, and actually  might 
> be a decent temporary measure on the way toward #3.  How about  that, 
> and then we can plan to publish it separately after 0.28?

I got this mostly done last night:

  <http://thepierianspring.org/perl/Module-Build.tar.gz>

I just need to review and test, hopefully getting one more round of 
tests from Win98 land. Also, I need to update the docs.

It mostly duplicates pl2bat with some minor exceptions, but it also 
cleaned up M::B::P::Windows.pm a good bit: eliminated the constructor 
override, the _find_pl2bat() method, and greatly simplified the 
make_executable() method. It works for me.

I'll problably check it in sometime this evening, after docs & review; 
there is no variation in this area on Win98 anymore, so I don't expect 
failure there related to this issue.

Randy.