Thread: [OMPT-svn-commit] SF.net SVN: modplug:[4035] trunk/OpenMPT (Page 50)

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Revision: 4035
          http://sourceforge.net/p/modplug/code/4035
Author:   saga-games
Date:     2014-05-03 21:29:42 +0000 (Sat, 03 May 2014)
Log Message:
-----------
[Fix] Ctrl+Enter could lead to crashes in previous build.
[Fix] With new installations (and probably also upgraded ones), it was possible that OpenMPT was internally rendering at a different sample rate than the sound device was outputting (https://forum.openmpt.org/index.php?topic=5265.0).
The current fix changes the default mix rate for sound device structs to 44KHz (was 48Khz) to be compatible with the default mix rate in the mixer. The problem is that somehow the 48KHz were not propagated to the mixer, so of course this is only a quick'n'easy fix for the new OpenMPT and still needs to be fixed properly.

[Doc] Updated release note documents.
[Mod] OpenMPT: Version is now 1.23.02.00

Modified Paths:
--------------
    trunk/OpenMPT/common/versionNumber.h
    trunk/OpenMPT/installer/install.iss
    trunk/OpenMPT/mptrack/View_tre.cpp
    trunk/OpenMPT/mptrack/manual_generator/run.sh
    trunk/OpenMPT/mptrack/manual_generator/wiki.py
    trunk/OpenMPT/packageTemplate/History.txt
    trunk/OpenMPT/packageTemplate/OMPT_1.23_ReleaseNotes.html
    trunk/OpenMPT/sounddev/SoundDevice.h

Modified: trunk/OpenMPT/common/versionNumber.h
===================================================================

--- trunk/OpenMPT/common/versionNumber.h	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/common/versionNumber.h	2014-05-03 21:29:42 UTC (rev 4035)
@@ -16,8 +16,8 @@
 //Version definitions. The only thing that needs to be changed when changing version number.
 #define VER_MAJORMAJOR          1
 #define VER_MAJOR               23
-#define VER_MINOR               01
-#define VER_MINORMINOR          04
+#define VER_MINOR               02
+#define VER_MINORMINOR          00
 
 //Version string. For example "1.17.02.28"
 #define MPT_VERSION_STR         VER_STRINGIZE(VER_MAJORMAJOR) "." VER_STRINGIZE(VER_MAJOR) "." VER_STRINGIZE(VER_MINOR) "." VER_STRINGIZE(VER_MINORMINOR)

Modified: trunk/OpenMPT/installer/install.iss
===================================================================
--- trunk/OpenMPT/installer/install.iss	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/installer/install.iss	2014-05-03 21:29:42 UTC (rev 4035)
@@ -76,7 +76,7 @@
 
 Source: packageTemplate\readme.txt; DestDir: {app}; Flags: ignoreversion
 Source: ..\packageTemplate\History.txt; DestDir: {app}; Flags: ignoreversion
-Source: ..\packageTemplate\OpenMPT Manual.pdf; DestDir: {app}; Flags: ignoreversion
+Source: ..\packageTemplate\OpenMPT Manual.chm; DestDir: {app}; Flags: ignoreversion
 
 ; release notes
 Source: ..\packageTemplate\ReleaseNotesImages\general\*.*; DestDir: {app}\ReleaseNotesImages\general\; Flags: ignoreversion sortfilesbyextension

Modified: trunk/OpenMPT/mptrack/View_tre.cpp
===================================================================
--- trunk/OpenMPT/mptrack/View_tre.cpp	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/mptrack/View_tre.cpp	2014-05-03 21:29:42 UTC (rev 4035)
@@ -273,7 +273,7 @@
 							CModScrollView *view = static_cast<CModScrollView *>(CMainFrame::GetMainFrame()->GetActiveView());
 							HTREEITEM hItem = GetSelectedItem();
 							const ModItem modItem = GetModItem(hItem);
-							if(view && modItem.type == MODITEM_INSLIB_SAMPLE || modItem.type == MODITEM_INSLIB_INSTRUMENT)
+							if(view && (modItem.type == MODITEM_INSLIB_SAMPLE || modItem.type == MODITEM_INSLIB_INSTRUMENT))
 							{
 								const mpt::PathString file = InsLibGetFullPath(hItem);
 								const char *className = view->GetRuntimeClass()->m_lpszClassName;

Modified: trunk/OpenMPT/mptrack/manual_generator/run.sh
===================================================================
--- trunk/OpenMPT/mptrack/manual_generator/run.sh	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/mptrack/manual_generator/run.sh	2014-05-03 21:29:42 UTC (rev 4035)
@@ -1,4 +1,5 @@
 #!/bin/bash
 rm -rf html/*.*
 mkdir html
-./wiki.py
\ No newline at end of file
+./wiki.py
+tar -cvzf html.tgz html
\ No newline at end of file

Modified: trunk/OpenMPT/mptrack/manual_generator/wiki.py
===================================================================
--- trunk/OpenMPT/mptrack/manual_generator/wiki.py	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/mptrack/manual_generator/wiki.py	2014-05-03 21:29:42 UTC (rev 4035)
@@ -63,10 +63,11 @@
 Full-text search=Yes
 Language=0x409 English (United States)
 Title=OpenMPT Manual
+Default Window=OpenMPT
 Default topic=""" + localurl(pages[0]) + """
 
 [WINDOWS]
-OpenMPT=,"OpenMPT Manual.hhc",,"" + localurl(pages[0]) + "",,,,,,0x42520,,0x300e,[50,50,750,550],0xb0000,,,,,,0
+OpenMPT=,"OpenMPT Manual.hhc",,""" + localurl(pages[0]) + """,,,,,,0x42520,215,0x300e,[20,20,780,580],0xb0000,,,,,,0
 
 [FILES]
 style.css

Modified: trunk/OpenMPT/packageTemplate/History.txt
===================================================================
--- trunk/OpenMPT/packageTemplate/History.txt	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/packageTemplate/History.txt	2014-05-03 21:29:42 UTC (rev 4035)
@@ -25,6 +25,61 @@
    <ks>    coda       / Ken Snyder
 
 
+v1.23.02.00 (3 May 2014, revision 4035)
+---------------------------------------
+General tab
+   [Fix] <js> Moving plugins unintentionally broke the plugin chain in many cases (http://bugs.openmpt.org/view.php?id=514).
+
+Pattern tab
+   [Imp] <js> Don't require shift key to be pressed when entering numeric effect letters on French keyboards (https://forum.openmpt.org/index.php?topic=5279.0).
+   [Imp] <js> Channel mute / channel mute on pattern transition shortcuts got extended to cover all channels covered by the selection instead of just the channel where the cursor is.
+   [Mod] <js> After pasting pattern data, the pasted area is automatically marked (http://bugs.openmpt.org/view.php?id=498).
+   [Fix] <js> When "loop pattern" was enabled, jumping between patterns could trigger sample syncing while playback was paused.
+   [Fix] <js> Other small fixes in playback adjustment code when jumping around.
+   [Fix] <js> Undoing channel deletion didn't work properly.
+   [Fix] <js> Dragging an order selection also works if the first selection point isn't visible.
+
+Sample tab
+   [New] <js> Added sample transpose shortcuts to quickly change the middle-C frequency.
+   [Fix] <js> Fade operation was broken in 64-bit builds (http://bugs.openmpt.org/view.php?id=507).
+   [Fix] <js> Crossfading sample loops modified one sampling point too much, which couldn't be undone properly.
+   [Imp] <js> WAV / FLAC saving: When there's only a sustain loop and no normal loop, ensure that it is treated as a sustain loop after reloading the sample (like it was done in older versions, tx dusthillguy).
+   [Fix] <js> Load / Save / New shortcuts are now also handled properly when the upper panel is focussed.
+   [Fix] <js> Adding silence to a sample that's not 8-bit mono broke in OpenMPT 1.23.
+
+Tree view
+   [New] <js> In the instrument library, Ctrl+Enter loads the selected instrument into the currently active sample / instrument editor window (http://bugs.openmpt.org/view.php?id=499).
+   [Imp] <js> Ctrl+Enter starts label editing.
+   [Fix] <js> Duplicating samples allocated way too much memory in the previous version, which could result in crashes (http://bugs.openmpt.org/view.php?id=505).
+
+VST::Plugin Bridge
+   [Fix] <js> Fixed KarmaFX EQ, a couple of VarietyOfSound plugins and possibly others that don't set any specific time flags, but still call audioMasterGetTime.
+
+Playback
+   [Imp] <js> For XM files, a new mix mode "Compatible (FT2 Pan Law)" has been added which is the same as the "compatible" mix mode, but this enforces FT2's pan law, while the "normal" compatible mix mode no longer does so. This should make tunes created with OpenMPT 1.22 or older not break drastically anymore if they make use of a lot of panning stuff.
+   [Fix] <js> Fixed potential crash in 64-bit version when playing certain songs with instrument envelopes (tx xTr1m).
+
+IT::Compatible Playback Mode
+   [Fix] <js> Sustained envelopes were released too early if the loop end was hit on exactly the same tick as the note-off event.
+
+MOD
+   [Imp] <js> Added ProTracker-style offset when note but no instrument number is specified in ProTracker 1/2 mode (fixes h0ffman's Revision 2014 tracked music entry).
+
+Module cleanup
+   [Fix] <js> Rearranging samples broke in the previous version (http://bugs.openmpt.org/view.php?id=497).
+
+Audio I/O
+   [Fix] <js> With new installations (and probably also upgraded ones), it was possible that OpenMPT was internally rendering at a different sample rate than the sound device was outputting (https://forum.openmpt.org/index.php?topic=5265.0).
+
+Misc
+   [Imp] <js> All parts of the Song Properties dialog are now updated instantly when switching between formats.
+   [Imp] <js> Made S3M amiga frequency limits option editable from the Song Properties dialog.
+   [Mod] <js> Changed manual format from PDF to CHM. When opening help from certain dialogs, the relevant manual page is automatically opened.
+   [Fix] <js> SF2 sample frequency conversion was broken in 64-bit builds (https://bugs.openmpt.org/view.php?id=508).
+   [Fix] <js> Modifying patterns, samples, etc. should now always update other views of the same type of the same module properly.
+   [Fix] <js> DefaultTemplate option was looking for the template file in the wrong paths.
+
+
 v1.23.01.00 (29 March 2014, revision 3998)
 ------------------------------------------
 General tab
@@ -381,7 +436,7 @@
 MOD
    [Fix] <js> EEx + Dxx on the same row causes the target row of Dxx to be skipped in ProTracker (fixes condom_corruption by Travolta).
    [Fix] <js> When using EEx, there should be only one "first tick" event. Ticks that are multiples of the song speed are longer treated as first ticks.
-   [Fix] <js> Frequency limiting was not always correct in PT 1.x mode (Fixes black_queen.mod).
+   [Fix] <js> Frequency limiting was not always correct in ProTracker 1.x mode (Fixes black_queen.mod).
    [Fix] <js> SoundTracker modules with "hidden" patterns in their order list didn't play properly anymore (probably since v1.22.03, affected e.g. Bad Dudes soundtrack).
 
 Other formats
@@ -1452,7 +1507,7 @@
 
 MOD::Loading
    [New] <js> Heuristic detection for VBlank MODs. Most MODs use the CIA timer instead of VBlank timing, but some don't.
-   [New] <js> Heuristic detection for PT 1.x playback mode: If there is pattern data that looks like it needs on-the-fly sample swapping, PT 1.x mode is enabled.
+   [New] <js> Heuristic detection for ProTracker 1.x playback mode: If there is pattern data that looks like it needs on-the-fly sample swapping, ProTracker 1.x mode is enabled.
    [New] <js> Heuristic detection for MODs with 7-bit panning, which is then automatically converted to 8-Bit panning.
    [Fix] <js> Tentative fix for MODs with short loops at the sample start that were most likely not intended.
 
@@ -2195,7 +2250,7 @@
    [Fix] <js> Don't ignore last pattern anymore if an XM file has no instruments.
 
 XM::Saving
-   [Imp] <js> Compatibility export: Export cuts off channels > 32.
+   [Imp] <js> Compatibility export: Only save up to 32 channels.
    [Imp] <js> Setting "OpenMPT <version number>" in the "made with" field (as any other tracker put their signature in here as well).
    [Fix] <js> Always save with a channel number that's a multiple of two so FT2 will load the file correctly.
    [Fix] <js> F20 won't turn into G20 anymore.
@@ -2212,14 +2267,14 @@
    [Fix] <js> Tempo slides won't exceed 255 BPM in compatible mode.
    [Fix] <js> In compatibility mode, retrigger with vxx on the same channel will always reset the retriggered note's volume.
    [Fix] <js> More compatible handling of Kxx effect.
-   [Fix] <js> Pattern loops are now handled correctly (using compatibility switch).
+   [Fix] <js> Pattern loops are now handled correctly.
    [Fix] <js> Out of range global volume, local global volume slides.
 
 MOD
    [Imp] <js> Module Creation: MOD files have 4 channels by default.
    [Imp] <js> Moved loop length check from compatibility export to normal save. There you go, Amiga users! :)
    [Fix] <js> Module Creation / Loading: Sane default volume settings for MOD / S3M files again (128 global volume, 48 sample volume).
-   [Fix] <js> Inserting more than 128 orders in MOD format is not possible anymore.
+   [Fix] <js> Inserting more than the allowed 128 orders in MOD format is not possible anymore.
 
 MOD::Loading
    [Fix] <js> Last pattern was not loading in .MODs that have no samples.
@@ -2904,10 +2959,9 @@
    [Fix] <rf> More fixes to plugs that try to get tempo before we've had a chance to init them properly.
    [Fix] <rf> Backed out first attempt at reducing hangs on stop (from rev. 1.13.2.10) - it was pointless. I think 1.13.2.11 really solved it though.
    [Fix] <rf> Fixed minor imprecision in \xx slide calculations.
-   [Fix] <rf> Minor GUI refresh fixes (tx xtr1m).
+   [Fix] <rf> Minor GUI refresh fixes (tx xTr1m).
 
 
-
 v1.17RC1 (revision 1.13.2.12)
 -----------------------------
    [Fix] <rf> Fix to plugs that try to get tempo before we've had a chance to init them properly.

Modified: trunk/OpenMPT/packageTemplate/OMPT_1.23_ReleaseNotes.html
===================================================================
--- trunk/OpenMPT/packageTemplate/OMPT_1.23_ReleaseNotes.html	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/packageTemplate/OMPT_1.23_ReleaseNotes.html	2014-05-03 21:29:42 UTC (rev 4035)
@@ -107,14 +107,14 @@
 
     <h3>General</h3>
     <ul>
-        <li>OpenMPT is now available as a native <strong>64-bit application</strong>!</li>
+        <li>OpenMPT is now available as native <strong>64-bit application</strong>!</li>
         <li><strong>Redo</strong> functionality for the pattern and sample editor.</li>
-        <li>A <strong>tempo tap</strong> button to quickly tap in the desired beats per minutes instead of guessing them.</li>
-        <li>Reduced <strong>clicks on badly looped samples</strong> when interpolation is turned on.</li>
+        <li>A <strong>tempo tap</strong> to quickly tap in the desired beats per minutes instead of guessing them.</li>
+        <li>Reduced <strong>clicks on looped samples</strong> when interpolation is turned on.</li>
         <li>Sound device settings are now <strong>remembered per device</strong>.</li>
         <li>Codec export settings are now remembered between sessions.</li>
         <li>Added options to open the sound device right at the program start and keep playing silence when stopping sound.</li>
-        <li>Support for <strong>unicode paths</strong> almost everywhere (just some internal settings that are written to the settings file might not be saved if the settings folder contains non-ANSI characters).</li>
+        <li>Support for <strong>unicode paths</strong> almost everywhere (just some internal settings that are written to the settings file might not be written correctly if the settings folder contains non-ANSI characters).</li>
         <li>OpenMPT (32-bit) is now <strong>large address aware</strong>, so more than 2 GB of RAM can be used for samples and plugins on systems where it's available.</li>
         <li>Restructured the settings dialog into some more logical divisions.</li>
         <li>Missing shortcuts from the default keyboard layout are now automatically added to other keyboard layouts.</li>
@@ -129,7 +129,7 @@
     <h3>Pattern Editor</h3>
     <ul>
         <li>Experimental new feature: Seeking in a module tries to <strong>keep sample sync</strong>, i.e. notes that are still playing from a previous pattern can still be heard. This can be enabled from the general options.</li>
-        <li>The <strong>Note Properites Dialog</strong> has been simplified from three tabs into one bigger dialog, with much better support for PC events.</li>
+        <li>The <strong>Note Properties Dialog</strong> has been simplified from three tabs into one bigger dialog, with much better support for PC events.</li>
         <li>Effect letter input should now work better on <strong>non-latin keyboard layouts</strong>, such as cyrillic.</li>
     </ul>
     
@@ -138,6 +138,7 @@
         <li><strong>Double-clicking the instrument library path</strong> (first item in the lower view) opens a folder browser dialog to quickly browse to a new location.</li>
         <li>The instrument library is now <strong>refreshed automatically</strong> when there are changes in the folder (e.g. adding new files).</li>
         <li>Backspace can now be used to <strong>go up one directory</strong> in the instrument library.</li>
+        <li>In the instrument library, Ctrl+Enter loads the selected instrument into the currently active sample / instrument editor window.</li>
     </ul>
     
     <h3>Plugins</h3>
@@ -180,10 +181,10 @@
         <i>This list has mostly been copied over from the old OpenMPT 1.17 RC2 release notes, so this not very comprehensive... :-)</i>
     </p>
     <ul>
-        <li>The plugin bridge is new and hasn't been tested very much yet. It is known that some plugins don't work in it at all (e.g. KarmaFX Equalizer). Custom plugin GUIs won't work in Wine. Please report any other issues you may be having with the plugin bridge!</li>
+        <li>The plugin bridge is new and hasn't been tested very much yet. It is known that some plugins don't work in it at all. Custom plugin GUIs are known to not work in Wine. Please report any other issues you may be having with the plugin bridge!</li>
         <li>Far from perfect VST support (no buses for audio / MIDI routing, only a few tracker effects are supported, etc...)</li>
-        <li>Previewing samples from the treeview's file browser stops the playing module.</li>
-        <li>Cannot preview instruments directly from the MIDI Library in the tree view.</li>
+        <li>Previewing samples from the tree view's file browser stops the playing module.</li>
+        <li>Cannot preview soundfont instruments directly from the MIDI Library in the tree view.</li>
         <li>Excessive performance drop when dragging over the graphical parameter editor during playback.</li>
         <li>The Right Alt (or Alt Gr) key is not handled well by the keyboard configuration.</li>
         <li>There is no really <em>convenient</em> way to find out what features of the tracker are supported by the original trackers (Impulse Tracker, Fasttracker 2, etc...) when working with those file formats...</li>

Modified: trunk/OpenMPT/sounddev/SoundDevice.h
===================================================================
--- trunk/OpenMPT/sounddev/SoundDevice.h	2014-05-03 15:43:50 UTC (rev 4034)
+++ trunk/OpenMPT/sounddev/SoundDevice.h	2014-05-03 21:29:42 UTC (rev 4035)
@@ -257,7 +257,7 @@
 		: hWnd(NULL)
 		, LatencyMS(100)
 		, UpdateIntervalMS(5)
-		, Samplerate(48000)
+		, Samplerate(44100)
 		, Channels(2)
 		, sampleFormat(SampleFormatFloat32)
 		, ExclusiveMode(false)

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.





Thread: [OMPT-svn-commit] SF.net SVN: modplug:[4035] trunk/OpenMPT (Page 50)

A music tracker software for Windows.

modplug-svn-commit