Author: sagamusix
Date: Fri Apr 12 20:01:57 2024
New Revision: 20578
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=20578
Log:
[Imp] XMF: Tighten validation of sample headers.
Modified:
trunk/OpenMPT/soundlib/Load_xmf.cpp
Modified: trunk/OpenMPT/soundlib/Load_xmf.cpp
==============================================================================
--- trunk/OpenMPT/soundlib/Load_xmf.cpp Fri Apr 12 11:12:33 2024 (r20577)
+++ trunk/OpenMPT/soundlib/Load_xmf.cpp Fri Apr 12 20:01:57 2024 (r20578)
@@ -50,6 +50,8 @@
return false;
if((flags & smpEnableLoop) && !loopEnd.get())
return false;
+ if(loopStart.get() > loopEnd.get() || loopStart.get() > length)
+ return false;
if(loopEnd.get() != 0 && (loopEnd.get() >= length || loopStart.get() >= loopEnd.get()))
return false;
return true;
|