Menu
▾
▴
modplug-svn-commit — OpenMPT subversion commit notifications
You can subscribe to this list here.
| 2006 |
Jan
|
Feb
|
Mar
(1) |
Apr
(1) |
May
|
Jun
(1) |
Jul
|
Aug
(10) |
Sep
|
Oct
|
Nov
|
Dec
(3) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2007 |
Jan
(1) |
Feb
(2) |
Mar
(3) |
Apr
(2) |
May
(10) |
Jun
(2) |
Jul
(1) |
Aug
|
Sep
|
Oct
|
Nov
(3) |
Dec
|
| 2008 |
Jan
(6) |
Feb
(4) |
Mar
(5) |
Apr
(2) |
May
(1) |
Jun
(1) |
Jul
(4) |
Aug
(6) |
Sep
(2) |
Oct
(9) |
Nov
(1) |
Dec
(4) |
| 2009 |
Jan
(9) |
Feb
(2) |
Mar
(2) |
Apr
(2) |
May
(6) |
Jun
(18) |
Jul
(33) |
Aug
(39) |
Sep
(33) |
Oct
(24) |
Nov
(23) |
Dec
(22) |
| 2010 |
Jan
(29) |
Feb
(32) |
Mar
(51) |
Apr
(17) |
May
(31) |
Jun
(21) |
Jul
(32) |
Aug
(28) |
Sep
(35) |
Oct
(27) |
Nov
(11) |
Dec
(13) |
| 2011 |
Jan
(14) |
Feb
(13) |
Mar
(27) |
Apr
(27) |
May
(28) |
Jun
(20) |
Jul
(43) |
Aug
(52) |
Sep
(66) |
Oct
(61) |
Nov
(11) |
Dec
(8) |
| 2012 |
Jan
(20) |
Feb
(30) |
Mar
(38) |
Apr
(21) |
May
(33) |
Jun
(21) |
Jul
(25) |
Aug
(9) |
Sep
(24) |
Oct
(42) |
Nov
(27) |
Dec
(41) |
| 2013 |
Jan
(20) |
Feb
(35) |
Mar
(156) |
Apr
(298) |
May
(258) |
Jun
(201) |
Jul
(105) |
Aug
(60) |
Sep
(193) |
Oct
(245) |
Nov
(280) |
Dec
(194) |
| 2014 |
Jan
(63) |
Feb
(202) |
Mar
(200) |
Apr
(23) |
May
(53) |
Jun
(105) |
Jul
(18) |
Aug
(26) |
Sep
(110) |
Oct
(187) |
Nov
(97) |
Dec
(74) |
| 2015 |
Jan
(45) |
Feb
(55) |
Mar
(116) |
Apr
(116) |
May
(193) |
Jun
(164) |
Jul
(50) |
Aug
(111) |
Sep
(98) |
Oct
(71) |
Nov
(103) |
Dec
(63) |
| 2016 |
Jan
(33) |
Feb
(101) |
Mar
(182) |
Apr
(139) |
May
(140) |
Jun
(103) |
Jul
(165) |
Aug
(286) |
Sep
(208) |
Oct
(127) |
Nov
(97) |
Dec
(54) |
| 2017 |
Jan
(64) |
Feb
(335) |
Mar
(202) |
Apr
(212) |
May
(139) |
Jun
(127) |
Jul
(294) |
Aug
(154) |
Sep
(170) |
Oct
(152) |
Nov
(156) |
Dec
(62) |
| 2018 |
Jan
(168) |
Feb
(237) |
Mar
(196) |
Apr
(174) |
May
(174) |
Jun
(161) |
Jul
(127) |
Aug
(88) |
Sep
(149) |
Oct
(66) |
Nov
(52) |
Dec
(135) |
| 2019 |
Jan
(146) |
Feb
(126) |
Mar
(104) |
Apr
(58) |
May
(60) |
Jun
(28) |
Jul
(197) |
Aug
(129) |
Sep
(141) |
Oct
(148) |
Nov
(63) |
Dec
(100) |
| 2020 |
Jan
(74) |
Feb
(37) |
Mar
(59) |
Apr
(154) |
May
(194) |
Jun
(133) |
Jul
(313) |
Aug
(197) |
Sep
(49) |
Oct
(162) |
Nov
(143) |
Dec
(57) |
| 2021 |
Jan
(120) |
Feb
(107) |
Mar
(314) |
Apr
(157) |
May
(524) |
Jun
(169) |
Jul
(72) |
Aug
(133) |
Sep
(135) |
Oct
(146) |
Nov
(198) |
Dec
(325) |
| 2022 |
Jan
(409) |
Feb
(249) |
Mar
(138) |
Apr
(95) |
May
(102) |
Jun
(221) |
Jul
(66) |
Aug
(120) |
Sep
(192) |
Oct
(131) |
Nov
(53) |
Dec
(171) |
| 2023 |
Jan
(357) |
Feb
(82) |
Mar
(168) |
Apr
(218) |
May
(196) |
Jun
(86) |
Jul
(115) |
Aug
(49) |
Sep
(190) |
Oct
(102) |
Nov
(45) |
Dec
(76) |
| 2024 |
Jan
(86) |
Feb
(50) |
Mar
(324) |
Apr
(209) |
May
(197) |
Jun
(232) |
Jul
(194) |
Aug
(247) |
Sep
(219) |
Oct
(266) |
Nov
(328) |
Dec
(304) |
| 2025 |
Jan
(191) |
Feb
(115) |
Mar
(137) |
Apr
(32) |
May
(126) |
Jun
(403) |
Jul
(72) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <sv...@op...> - 2025-02-15 16:24:56
|
Author: manx Date: Sat Feb 15 17:24:49 2025 New Revision: 22896 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22896 Log: Merged revision(s) 22890 from trunk/OpenMPT: [Fix] build: Autotools: Fix typo in linker option --no-undefined. ........ Modified: branches/OpenMPT-1.28/ (props changed) branches/OpenMPT-1.28/build/autotools/Makefile.am Modified: branches/OpenMPT-1.28/build/autotools/Makefile.am ============================================================================== --- branches/OpenMPT-1.28/build/autotools/Makefile.am Sat Feb 15 17:24:21 2025 (r22895) +++ branches/OpenMPT-1.28/build/autotools/Makefile.am Sat Feb 15 17:24:49 2025 (r22896) @@ -363,7 +363,7 @@ pkgconfig_DATA += libopenmpt/libopenmpt.pc lib_LTLIBRARIES += libopenmpt.la -libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) -no-undefined +libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) --no-undefined nobase_include_HEADERS += libopenmpt/libopenmpt.h nobase_include_HEADERS += libopenmpt/libopenmpt.hpp nobase_include_HEADERS += libopenmpt/libopenmpt_version.h |
|
From: <sv...@op...> - 2025-02-15 16:24:27
|
Author: manx Date: Sat Feb 15 17:24:21 2025 New Revision: 22895 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22895 Log: [Fix] libmodplug-0.8.8.5: Fix typo in linker option --no-undefined. [Mod] libmodplug-0.8.8.5: Version is now 0.8.8.5-openmpt2. Modified: trunk/OpenMPT/contrib/libmodplug-0.8.8.5/Makefile.am trunk/OpenMPT/contrib/libmodplug-0.8.8.5/configure.ac Modified: trunk/OpenMPT/contrib/libmodplug-0.8.8.5/Makefile.am ============================================================================== --- trunk/OpenMPT/contrib/libmodplug-0.8.8.5/Makefile.am Sat Feb 15 17:23:53 2025 (r22894) +++ trunk/OpenMPT/contrib/libmodplug-0.8.8.5/Makefile.am Sat Feb 15 17:24:21 2025 (r22895) @@ -21,7 +21,7 @@ if ENABLE_LIBOPENMPT_MODPLUG lib_LTLIBRARIES += libopenmpt_modplug.la -libopenmpt_modplug_la_LDFLAGS = -version-info 1:0:0 -no-undefined +libopenmpt_modplug_la_LDFLAGS = -version-info 1:0:0 --no-undefined libopenmpt_modplug_la_CPPFLAGS = -I$(srcdir)/ $(LIBOPENMPT_CPPFLAGS) libopenmpt_modplug_la_CXXFLAGS = $(LIBOPENMPT_CFLAGS) libopenmpt_modplug_la_CFLAGS = $(LIBOPENMPT_CFLAGS) @@ -34,7 +34,7 @@ if ENABLE_LIBMODPLUG pkgconfig_DATA += libmodplug.pc lib_LTLIBRARIES += libmodplug.la -libmodplug_la_LDFLAGS = -version-info 1:0:0 -no-undefined +libmodplug_la_LDFLAGS = -version-info 1:0:0 --no-undefined nobase_include_HEADERS += libmodplug/modplug.h libmodplug/sndfile.h libmodplug/stdafx.h libmodplug_la_CPPFLAGS = -I$(srcdir)/ $(LIBOPENMPT_CPPFLAGS) libmodplug_la_CXXFLAGS = $(LIBOPENMPT_CFLAGS) Modified: trunk/OpenMPT/contrib/libmodplug-0.8.8.5/configure.ac ============================================================================== --- trunk/OpenMPT/contrib/libmodplug-0.8.8.5/configure.ac Sat Feb 15 17:23:53 2025 (r22894) +++ trunk/OpenMPT/contrib/libmodplug-0.8.8.5/configure.ac Sat Feb 15 17:24:21 2025 (r22895) @@ -1,4 +1,4 @@ -AC_INIT([libopenmpt-modplug], [0.8.8.5-openmpt1], [https://bugs.openmpt.org/], [libopenmpt-modplug], [https://lib.openmpt.org/]) +AC_INIT([libopenmpt-modplug], [0.8.8.5-openmpt2], [https://bugs.openmpt.org/], [libopenmpt-modplug], [https://lib.openmpt.org/]) AC_PREREQ([2.68]) AC_CONFIG_MACRO_DIR([m4]) |
|
From: <sv...@op...> - 2025-02-15 16:24:05
|
Author: manx Date: Sat Feb 15 17:23:53 2025 New Revision: 22894 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22894 Log: [Fix] libmodplug-0.8.9.0: Fix typo in linker option --no-undefined. [Mod] libmodplug-0.8.9.0: Version is now 0.8.9.0-openmpt2. Modified: trunk/OpenMPT/contrib/libmodplug-0.8.9.0/Makefile.am trunk/OpenMPT/contrib/libmodplug-0.8.9.0/configure.ac Modified: trunk/OpenMPT/contrib/libmodplug-0.8.9.0/Makefile.am ============================================================================== --- trunk/OpenMPT/contrib/libmodplug-0.8.9.0/Makefile.am Sat Feb 15 17:19:14 2025 (r22893) +++ trunk/OpenMPT/contrib/libmodplug-0.8.9.0/Makefile.am Sat Feb 15 17:23:53 2025 (r22894) @@ -21,7 +21,7 @@ if ENABLE_LIBOPENMPT_MODPLUG lib_LTLIBRARIES += libopenmpt_modplug.la -libopenmpt_modplug_la_LDFLAGS = -version-info 1:0:0 -no-undefined +libopenmpt_modplug_la_LDFLAGS = -version-info 1:0:0 --no-undefined libopenmpt_modplug_la_CPPFLAGS = -I$(srcdir)/ $(LIBOPENMPT_CPPFLAGS) libopenmpt_modplug_la_CXXFLAGS = $(LIBOPENMPT_CFLAGS) libopenmpt_modplug_la_CFLAGS = $(LIBOPENMPT_CFLAGS) @@ -34,7 +34,7 @@ if ENABLE_LIBMODPLUG pkgconfig_DATA += libmodplug.pc lib_LTLIBRARIES += libmodplug.la -libmodplug_la_LDFLAGS = -version-info 1:0:0 -no-undefined +libmodplug_la_LDFLAGS = -version-info 1:0:0 --no-undefined nobase_include_HEADERS += libmodplug/modplug.h libmodplug/sndfile.h libmodplug/stdafx.h libmodplug_la_CPPFLAGS = -I$(srcdir)/ $(LIBOPENMPT_CPPFLAGS) libmodplug_la_CXXFLAGS = $(LIBOPENMPT_CFLAGS) Modified: trunk/OpenMPT/contrib/libmodplug-0.8.9.0/configure.ac ============================================================================== --- trunk/OpenMPT/contrib/libmodplug-0.8.9.0/configure.ac Sat Feb 15 17:19:14 2025 (r22893) +++ trunk/OpenMPT/contrib/libmodplug-0.8.9.0/configure.ac Sat Feb 15 17:23:53 2025 (r22894) @@ -1,4 +1,4 @@ -AC_INIT([libopenmpt-modplug], [0.8.9.0-openmpt1], [https://bugs.openmpt.org/], [libopenmpt-modplug], [https://lib.openmpt.org/]) +AC_INIT([libopenmpt-modplug], [0.8.9.0-openmpt2], [https://bugs.openmpt.org/], [libopenmpt-modplug], [https://lib.openmpt.org/]) AC_PREREQ([2.68]) AC_CONFIG_MACRO_DIR([m4]) |
|
From: <sv...@op...> - 2025-02-15 16:19:26
|
Author: manx Date: Sat Feb 15 17:19:14 2025 New Revision: 22893 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22893 Log: Merged revision(s) 22890 from trunk/OpenMPT: [Fix] build: Autotools: Fix typo in linker option --no-undefined. ........ Modified: branches/OpenMPT-1.29/ (props changed) branches/OpenMPT-1.29/build/autotools/Makefile.am Modified: branches/OpenMPT-1.29/build/autotools/Makefile.am ============================================================================== --- branches/OpenMPT-1.29/build/autotools/Makefile.am Sat Feb 15 17:18:44 2025 (r22892) +++ branches/OpenMPT-1.29/build/autotools/Makefile.am Sat Feb 15 17:19:14 2025 (r22893) @@ -371,7 +371,7 @@ pkgconfig_DATA += libopenmpt/libopenmpt.pc lib_LTLIBRARIES += libopenmpt.la -libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) -no-undefined +libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) --no-undefined nobase_include_HEADERS += libopenmpt/libopenmpt.h nobase_include_HEADERS += libopenmpt/libopenmpt.hpp nobase_include_HEADERS += libopenmpt/libopenmpt_version.h |
|
From: <sv...@op...> - 2025-02-15 16:19:01
|
Author: manx Date: Sat Feb 15 17:18:44 2025 New Revision: 22892 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22892 Log: Merged revision(s) 22890 from trunk/OpenMPT: [Fix] build: Autotools: Fix typo in linker option --no-undefined. ........ Modified: branches/OpenMPT-1.30/ (props changed) branches/OpenMPT-1.30/build/autotools/Makefile.am Modified: branches/OpenMPT-1.30/build/autotools/Makefile.am ============================================================================== --- branches/OpenMPT-1.30/build/autotools/Makefile.am Sat Feb 15 17:18:16 2025 (r22891) +++ branches/OpenMPT-1.30/build/autotools/Makefile.am Sat Feb 15 17:18:44 2025 (r22892) @@ -512,7 +512,7 @@ pkgconfig_DATA += libopenmpt/libopenmpt.pc lib_LTLIBRARIES += libopenmpt.la -libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) -no-undefined +libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) --no-undefined nobase_include_HEADERS += libopenmpt/libopenmpt.h nobase_include_HEADERS += libopenmpt/libopenmpt.hpp nobase_include_HEADERS += libopenmpt/libopenmpt_version.h |
|
From: <sv...@op...> - 2025-02-15 16:18:28
|
Author: manx Date: Sat Feb 15 17:18:16 2025 New Revision: 22891 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22891 Log: Merged revision(s) 22890 from trunk/OpenMPT: [Fix] build: Autotools: Fix typo in linker option --no-undefined. ........ Modified: branches/OpenMPT-1.31/ (props changed) branches/OpenMPT-1.31/build/autotools/Makefile.am Modified: branches/OpenMPT-1.31/build/autotools/Makefile.am ============================================================================== --- branches/OpenMPT-1.31/build/autotools/Makefile.am Sat Feb 15 17:16:46 2025 (r22890) +++ branches/OpenMPT-1.31/build/autotools/Makefile.am Sat Feb 15 17:18:16 2025 (r22891) @@ -546,7 +546,7 @@ pkgconfig_DATA += libopenmpt/libopenmpt.pc lib_LTLIBRARIES += libopenmpt.la -libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) -no-undefined +libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) --no-undefined includelibopenmpt_HEADERS += libopenmpt/libopenmpt.h includelibopenmpt_HEADERS += libopenmpt/libopenmpt.hpp includelibopenmpt_HEADERS += libopenmpt/libopenmpt_version.h |
|
From: <sv...@op...> - 2025-02-15 16:17:01
|
Author: manx Date: Sat Feb 15 17:16:46 2025 New Revision: 22890 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22890 Log: [Fix] build: Autotools: Fix typo in linker option --no-undefined. Modified: trunk/OpenMPT/build/autotools/Makefile.am Modified: trunk/OpenMPT/build/autotools/Makefile.am ============================================================================== --- trunk/OpenMPT/build/autotools/Makefile.am Sat Feb 15 17:12:54 2025 (r22889) +++ trunk/OpenMPT/build/autotools/Makefile.am Sat Feb 15 17:16:46 2025 (r22890) @@ -583,7 +583,7 @@ pkgconfig_DATA += libopenmpt/libopenmpt.pc lib_LTLIBRARIES += libopenmpt.la -libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) -no-undefined +libopenmpt_la_LDFLAGS = -version-info $(LIBOPENMPT_LTVER_CURRENT):$(LIBOPENMPT_LTVER_REVISION):$(LIBOPENMPT_LTVER_AGE) --no-undefined includelibopenmpt_HEADERS += libopenmpt/libopenmpt.h includelibopenmpt_HEADERS += libopenmpt/libopenmpt.hpp includelibopenmpt_HEADERS += libopenmpt/libopenmpt_version.h |
|
From: <sv...@op...> - 2025-02-15 16:13:00
|
Author: manx Date: Sat Feb 15 17:12:54 2025 New Revision: 22889 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22889 Log: [Ref] mpt/check/compiler.hpp: Detect missing exceptions support on MSVC. Modified: trunk/OpenMPT/src/mpt/check/compiler.hpp Modified: trunk/OpenMPT/src/mpt/check/compiler.hpp ============================================================================== --- trunk/OpenMPT/src/mpt/check/compiler.hpp Sat Feb 15 17:12:03 2025 (r22888) +++ trunk/OpenMPT/src/mpt/check/compiler.hpp Sat Feb 15 17:12:54 2025 (r22889) @@ -38,11 +38,15 @@ #endif #ifndef MPT_CHECK_CXX_IGNORE_WARNING_NO_EXCEPTIONS -#if MPT_COMPILER_GCC +#if MPT_COMPILER_MSVC +#if !defined(_CPPUNWIND) +MPT_WARNING("C++ compiler has no exception support.") +#endif +#elif MPT_COMPILER_GCC #if (!defined(__EXCEPTIONS) || (__EXCEPTIONS != 1)) MPT_WARNING("C++ compiler has no exception support.") #endif -#elif MPT_COMPILER_CLANG && !defined(_MSC_VER) +#elif MPT_COMPILER_CLANG #if (!defined(__EXCEPTIONS) || (__EXCEPTIONS != 1)) MPT_WARNING("C++ compiler has no exception support.") #endif |
|
From: <sv...@op...> - 2025-02-15 16:12:10
|
Author: manx Date: Sat Feb 15 17:12:03 2025 New Revision: 22888 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22888 Log: Merged revision(s) 22886 from trunk/OpenMPT: [Ref] mpt/base/detect_compiler.hpp: Detect VS2022 17.13. ........ Modified: branches/OpenMPT-1.30/ (props changed) branches/OpenMPT-1.30/src/mpt/base/detect_compiler.hpp Modified: branches/OpenMPT-1.30/src/mpt/base/detect_compiler.hpp ============================================================================== --- branches/OpenMPT-1.30/src/mpt/base/detect_compiler.hpp Sat Feb 15 17:11:42 2025 (r22887) +++ branches/OpenMPT-1.30/src/mpt/base/detect_compiler.hpp Sat Feb 15 17:12:03 2025 (r22888) @@ -50,7 +50,9 @@ #elif defined(_MSC_VER) #define MPT_COMPILER_MSVC 1 -#if (_MSC_VER >= 1942) +#if (_MSC_VER >= 1943) +#define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 13) +#elif (_MSC_VER >= 1942) #define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 12) #elif (_MSC_VER >= 1941) #define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 11) |
|
From: <sv...@op...> - 2025-02-15 16:11:48
|
Author: manx Date: Sat Feb 15 17:11:42 2025 New Revision: 22887 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22887 Log: Merged revision(s) 22886 from trunk/OpenMPT: [Ref] mpt/base/detect_compiler.hpp: Detect VS2022 17.13. ........ Modified: branches/OpenMPT-1.31/ (props changed) branches/OpenMPT-1.31/src/mpt/base/detect_compiler.hpp Modified: branches/OpenMPT-1.31/src/mpt/base/detect_compiler.hpp ============================================================================== --- branches/OpenMPT-1.31/src/mpt/base/detect_compiler.hpp Sat Feb 15 17:11:16 2025 (r22886) +++ branches/OpenMPT-1.31/src/mpt/base/detect_compiler.hpp Sat Feb 15 17:11:42 2025 (r22887) @@ -50,7 +50,9 @@ #elif defined(_MSC_VER) #define MPT_COMPILER_MSVC 1 -#if (_MSC_VER >= 1942) +#if (_MSC_VER >= 1943) +#define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 13) +#elif (_MSC_VER >= 1942) #define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 12) #elif (_MSC_VER >= 1941) #define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 11) |
|
From: <sv...@op...> - 2025-02-15 16:11:23
|
Author: manx Date: Sat Feb 15 17:11:16 2025 New Revision: 22886 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22886 Log: [Ref] mpt/base/detect_compiler.hpp: Detect VS2022 17.13. Modified: trunk/OpenMPT/src/mpt/base/detect_compiler.hpp Modified: trunk/OpenMPT/src/mpt/base/detect_compiler.hpp ============================================================================== --- trunk/OpenMPT/src/mpt/base/detect_compiler.hpp Sat Feb 15 17:06:58 2025 (r22885) +++ trunk/OpenMPT/src/mpt/base/detect_compiler.hpp Sat Feb 15 17:11:16 2025 (r22886) @@ -50,7 +50,9 @@ #elif defined(_MSC_VER) #define MPT_COMPILER_MSVC 1 -#if (_MSC_VER >= 1942) +#if (_MSC_VER >= 1943) +#define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 13) +#elif (_MSC_VER >= 1942) #define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 12) #elif (_MSC_VER >= 1941) #define MPT_COMPILER_MSVC_VERSION MPT_COMPILER_MAKE_VERSION2(2022, 11) |
|
From: <sv...@op...> - 2025-02-15 16:07:05
|
Author: manx Date: Sat Feb 15 17:06:58 2025 New Revision: 22885 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22885 Log: [Ref] libopenmpt: Use std::string_view::operator== instead of std::strcmp. Modified: trunk/OpenMPT/libopenmpt/libopenmpt_c.cpp Modified: trunk/OpenMPT/libopenmpt/libopenmpt_c.cpp ============================================================================== --- trunk/OpenMPT/libopenmpt/libopenmpt_c.cpp Sat Feb 15 16:59:56 2025 (r22884) +++ trunk/OpenMPT/libopenmpt/libopenmpt_c.cpp Sat Feb 15 17:06:58 2025 (r22885) @@ -23,11 +23,11 @@ #include <limits> #include <new> #include <stdexcept> +#include <string_view> #include <cmath> #include <cstdio> #include <cstdlib> -#include <cstring> #if defined(_MSC_VER) #pragma warning(disable:4702) /* unreachable code */ @@ -1910,12 +1910,13 @@ openmpt::interface::check_pointer( interface ); std::memset( interface, 0, interface_size ); int result = 0; - if ( !std::strcmp( interface_id, "" ) ) { + std::string_view interface_id_sv = interface_id; + if ( interface_id_sv == "" ) { result = 0; - } else if ( !std::strcmp( interface_id, LIBOPENMPT_EXT_C_INTERFACE_PATTERN_VIS ) && ( interface_size == sizeof( openmpt_module_ext_interface_pattern_vis ) ) ) { + } else if ( ( interface_id_sv == LIBOPENMPT_EXT_C_INTERFACE_PATTERN_VIS ) && ( interface_size == sizeof( openmpt_module_ext_interface_pattern_vis ) ) ) { openmpt_module_ext_interface_pattern_vis * i = static_cast< openmpt_module_ext_interface_pattern_vis * >( interface ); i->get_pattern_row_channel_volume_effect_type = &get_pattern_row_channel_volume_effect_type; i->get_pattern_row_channel_effect_type = &get_pattern_row_channel_effect_type; @@ -1923,7 +1924,7 @@ - } else if ( !std::strcmp( interface_id, LIBOPENMPT_EXT_C_INTERFACE_INTERACTIVE ) && ( interface_size == sizeof( openmpt_module_ext_interface_interactive ) ) ) { + } else if ( ( interface_id_sv == LIBOPENMPT_EXT_C_INTERFACE_INTERACTIVE ) && ( interface_size == sizeof( openmpt_module_ext_interface_interactive ) ) ) { openmpt_module_ext_interface_interactive * i = static_cast< openmpt_module_ext_interface_interactive * >( interface ); i->set_current_speed = &set_current_speed; i->set_current_tempo = &set_current_tempo; @@ -1945,7 +1946,7 @@ - } else if ( !std::strcmp( interface_id, LIBOPENMPT_EXT_C_INTERFACE_INTERACTIVE2 ) && ( interface_size == sizeof( openmpt_module_ext_interface_interactive2 ) ) ) { + } else if ( ( interface_id_sv == LIBOPENMPT_EXT_C_INTERFACE_INTERACTIVE2 ) && ( interface_size == sizeof( openmpt_module_ext_interface_interactive2 ) ) ) { openmpt_module_ext_interface_interactive2 * i = static_cast< openmpt_module_ext_interface_interactive2 * >( interface ); i->note_off = ¬e_off; i->note_fade = ¬e_fade; @@ -1957,7 +1958,7 @@ - } else if ( !std::strcmp( interface_id, LIBOPENMPT_EXT_C_INTERFACE_INTERACTIVE3 ) && ( interface_size == sizeof( openmpt_module_ext_interface_interactive3 ) ) ) { + } else if ( ( interface_id_sv == LIBOPENMPT_EXT_C_INTERFACE_INTERACTIVE3 ) && ( interface_size == sizeof( openmpt_module_ext_interface_interactive3 ) ) ) { openmpt_module_ext_interface_interactive3 * i = static_cast< openmpt_module_ext_interface_interactive3 * >( interface ); i->set_current_tempo2 = &set_current_tempo2; result = 1; |
|
From: <sv...@op...> - 2025-02-15 16:00:08
|
Author: manx Date: Sat Feb 15 16:59:56 2025 New Revision: 22884 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22884 Log: [Imp] build: Makefile: Unconditionally set --no-undefined linker option. Without the typo, this should hopefully work on all supported platforms. Modified: trunk/OpenMPT/build/make/warnings-clang.mk trunk/OpenMPT/build/make/warnings-gcc.mk Modified: trunk/OpenMPT/build/make/warnings-clang.mk ============================================================================== --- trunk/OpenMPT/build/make/warnings-clang.mk Sat Feb 15 16:53:09 2025 (r22883) +++ trunk/OpenMPT/build/make/warnings-clang.mk Sat Feb 15 16:59:56 2025 (r22884) @@ -15,10 +15,12 @@ #CXXFLAGS_WARNINGS += -Wconversion #CXXFLAGS_WARNINGS += -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-c++98-c++11-c++14-compat -Wno-padded -Wno-weak-vtables -Wno-sign-conversion -Wno-shadow-field-in-constructor -Wno-conversion -Wno-switch-enum -Wno-old-style-cast +LDFLAGS_WARNINGS += -Wl,--no-undefined + ifeq ($(MODERN),1) CXXFLAGS_WARNINGS += CFLAGS_WARNINGS += -LDFLAGS_WARNINGS += -Wl,--no-undefined +LDFLAGS_WARNINGS += endif CFLAGS_SILENT += -Wno-\#warnings Modified: trunk/OpenMPT/build/make/warnings-gcc.mk ============================================================================== --- trunk/OpenMPT/build/make/warnings-gcc.mk Sat Feb 15 16:53:09 2025 (r22883) +++ trunk/OpenMPT/build/make/warnings-gcc.mk Sat Feb 15 16:59:56 2025 (r22884) @@ -4,6 +4,8 @@ CXXFLAGS_WARNINGS += -Wno-psabi +LDFLAGS_WARNINGS += -Wl,--no-undefined + ifeq ($(MODERN),1) # GCC >= 12 # -Wconversion is way too noisy for earlier GCC versions @@ -11,7 +13,7 @@ #CXXFLAGS_WARNINGS += -Wshadow -Wswitch-enum CXXFLAGS_WARNINGS += -Wconversion # gold -LDFLAGS_WARNINGS += -Wl,--no-undefined -Wl,--detect-odr-violations +LDFLAGS_WARNINGS += -Wl,--detect-odr-violations # GCC 8 CXXFLAGS_WARNINGS += -Wcast-align=strict CFLAGS_WARNINGS += -Wcast-align=strict |
|
From: <sv...@op...> - 2025-02-15 15:53:22
|
Author: manx Date: Sat Feb 15 16:53:09 2025 New Revision: 22883 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22883 Log: Merged revision(s) 22882 from branches/OpenMPT-1.29: Merged revision(s) 22879 from trunk/OpenMPT: [Fix] build: Makefile: GCC: Fix typo in linker option --no-undefined. [Fix] build: Makefile: Clang: Fix typo in linker option --no-undefined. ........ ........ Modified: branches/OpenMPT-1.28/ (props changed) branches/OpenMPT-1.28/build/make/config-clang.mk branches/OpenMPT-1.28/build/make/config-gcc.mk Modified: branches/OpenMPT-1.28/build/make/config-clang.mk ============================================================================== --- branches/OpenMPT-1.28/build/make/config-clang.mk Sat Feb 15 16:51:22 2025 (r22882) +++ branches/OpenMPT-1.28/build/make/config-clang.mk Sat Feb 15 16:53:09 2025 (r22883) @@ -53,7 +53,7 @@ #CXXFLAGS_WARNINGS += -Wdouble-promotion -Wframe-larger-than=16000 CFLAGS_WARNINGS += -Wpedantic -Wframe-larger-than=4000 #CFLAGS_WARNINGS += -Wdouble-promotion -LDFLAGS_WARNINGS += -Wl,-no-undefined +LDFLAGS_WARNINGS += -Wl,--no-undefined CXXFLAGS_WARNINGS += -Wdeprecated -Wextra-semi -Wnon-virtual-dtor -Wreserved-id-macro endif Modified: branches/OpenMPT-1.28/build/make/config-gcc.mk ============================================================================== --- branches/OpenMPT-1.28/build/make/config-gcc.mk Sat Feb 15 16:51:22 2025 (r22882) +++ branches/OpenMPT-1.28/build/make/config-gcc.mk Sat Feb 15 16:53:09 2025 (r22883) @@ -46,7 +46,7 @@ #CXXFLAGS_WARNINGS += -Wdouble-promotion CFLAGS_WARNINGS += -Wpedantic -Wlogical-op -Wframe-larger-than=4000 #CFLAGS_WARNINGS += -Wdouble-promotion -LDFLAGS_WARNINGS += -Wl,-no-undefined -Wl,--detect-odr-violations +LDFLAGS_WARNINGS += -Wl,--no-undefined -Wl,--detect-odr-violations CXXFLAGS_WARNINGS += -Wsuggest-override endif |
|
From: <sv...@op...> - 2025-02-15 15:51:29
|
Author: manx Date: Sat Feb 15 16:51:22 2025 New Revision: 22882 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22882 Log: Merged revision(s) 22879 from trunk/OpenMPT: [Fix] build: Makefile: GCC: Fix typo in linker option --no-undefined. [Fix] build: Makefile: Clang: Fix typo in linker option --no-undefined. ........ Modified: branches/OpenMPT-1.29/ (props changed) branches/OpenMPT-1.29/build/make/config-clang.mk branches/OpenMPT-1.29/build/make/config-gcc.mk Modified: branches/OpenMPT-1.29/build/make/config-clang.mk ============================================================================== --- branches/OpenMPT-1.29/build/make/config-clang.mk Sat Feb 15 16:49:13 2025 (r22881) +++ branches/OpenMPT-1.29/build/make/config-clang.mk Sat Feb 15 16:51:22 2025 (r22882) @@ -49,7 +49,7 @@ LDFLAGS += -fuse-ld=lld CXXFLAGS_WARNINGS += -Wpedantic -Wframe-larger-than=16000 CFLAGS_WARNINGS += -Wpedantic -Wframe-larger-than=4000 -LDFLAGS_WARNINGS += -Wl,-no-undefined +LDFLAGS_WARNINGS += -Wl,--no-undefined # re-renable after 1.29 branch #CXXFLAGS_WARNINGS += -Wdouble-promotion #CFLAGS_WARNINGS += -Wdouble-promotion Modified: branches/OpenMPT-1.29/build/make/config-gcc.mk ============================================================================== --- branches/OpenMPT-1.29/build/make/config-gcc.mk Sat Feb 15 16:49:13 2025 (r22881) +++ branches/OpenMPT-1.29/build/make/config-gcc.mk Sat Feb 15 16:51:22 2025 (r22882) @@ -38,7 +38,7 @@ LDFLAGS += -fuse-ld=gold CXXFLAGS_WARNINGS += -Wpedantic -Wlogical-op -Wframe-larger-than=16000 CFLAGS_WARNINGS += -Wpedantic -Wlogical-op -Wframe-larger-than=4000 -LDFLAGS_WARNINGS += -Wl,-no-undefined -Wl,--detect-odr-violations +LDFLAGS_WARNINGS += -Wl,--no-undefined -Wl,--detect-odr-violations # re-renable after 1.29 branch #CXXFLAGS_WARNINGS += -Wdouble-promotion #CFLAGS_WARNINGS += -Wdouble-promotion |
|
From: <sv...@op...> - 2025-02-15 15:49:26
|
Author: manx Date: Sat Feb 15 16:49:13 2025 New Revision: 22881 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22881 Log: Merged revision(s) 22879 from trunk/OpenMPT: [Fix] build: Makefile: GCC: Fix typo in linker option --no-undefined. [Fix] build: Makefile: Clang: Fix typo in linker option --no-undefined. ........ Modified: branches/OpenMPT-1.30/ (props changed) branches/OpenMPT-1.30/build/make/warnings-clang.mk branches/OpenMPT-1.30/build/make/warnings-gcc.mk Modified: branches/OpenMPT-1.30/build/make/warnings-clang.mk ============================================================================== --- branches/OpenMPT-1.30/build/make/warnings-clang.mk Sat Feb 15 16:48:50 2025 (r22880) +++ branches/OpenMPT-1.30/build/make/warnings-clang.mk Sat Feb 15 16:49:13 2025 (r22881) @@ -16,7 +16,7 @@ endif CXXFLAGS_WARNINGS += CFLAGS_WARNINGS += -Wframe-larger-than=4000 -LDFLAGS_WARNINGS += -Wl,-no-undefined +LDFLAGS_WARNINGS += -Wl,--no-undefined # re-renable after 1.29 branch #CXXFLAGS_WARNINGS += -Wdouble-promotion #CFLAGS_WARNINGS += -Wdouble-promotion Modified: branches/OpenMPT-1.30/build/make/warnings-gcc.mk ============================================================================== --- branches/OpenMPT-1.30/build/make/warnings-gcc.mk Sat Feb 15 16:48:50 2025 (r22880) +++ branches/OpenMPT-1.30/build/make/warnings-gcc.mk Sat Feb 15 16:49:13 2025 (r22881) @@ -9,7 +9,7 @@ CXXFLAGS_WARNINGS += CFLAGS_WARNINGS += -Wframe-larger-than=4000 #CXXFLAGS_WARNINGS += -Wstrict-aliasing -Wpointer-arith -Winit-self -Wshadow -Wswitch-enum -Wstrict-prototypes -LDFLAGS_WARNINGS += -Wl,-no-undefined -Wl,--detect-odr-violations +LDFLAGS_WARNINGS += -Wl,--no-undefined -Wl,--detect-odr-violations # re-renable after 1.29 branch #CXXFLAGS_WARNINGS += -Wdouble-promotion #CFLAGS_WARNINGS += -Wdouble-promotion |
|
From: <sv...@op...> - 2025-02-15 15:49:03
|
Author: manx Date: Sat Feb 15 16:48:50 2025 New Revision: 22880 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22880 Log: Merged revision(s) 22879 from trunk/OpenMPT: [Fix] build: Makefile: GCC: Fix typo in linker option --no-undefined. [Fix] build: Makefile: Clang: Fix typo in linker option --no-undefined. ........ Modified: branches/OpenMPT-1.31/ (props changed) branches/OpenMPT-1.31/build/make/warnings-clang.mk branches/OpenMPT-1.31/build/make/warnings-gcc.mk Modified: branches/OpenMPT-1.31/build/make/warnings-clang.mk ============================================================================== --- branches/OpenMPT-1.31/build/make/warnings-clang.mk Sat Feb 15 16:48:02 2025 (r22879) +++ branches/OpenMPT-1.31/build/make/warnings-clang.mk Sat Feb 15 16:48:50 2025 (r22880) @@ -18,7 +18,7 @@ ifeq ($(MODERN),1) CXXFLAGS_WARNINGS += CFLAGS_WARNINGS += -LDFLAGS_WARNINGS += -Wl,-no-undefined +LDFLAGS_WARNINGS += -Wl,--no-undefined endif CFLAGS_SILENT += -Wno-\#warnings Modified: branches/OpenMPT-1.31/build/make/warnings-gcc.mk ============================================================================== --- branches/OpenMPT-1.31/build/make/warnings-gcc.mk Sat Feb 15 16:48:02 2025 (r22879) +++ branches/OpenMPT-1.31/build/make/warnings-gcc.mk Sat Feb 15 16:48:50 2025 (r22880) @@ -8,7 +8,7 @@ CFLAGS_WARNINGS += -Wframe-larger-than=4000 #CXXFLAGS_WARNINGS += -Wshadow -Wswitch-enum # gold -LDFLAGS_WARNINGS += -Wl,-no-undefined -Wl,--detect-odr-violations +LDFLAGS_WARNINGS += -Wl,--no-undefined -Wl,--detect-odr-violations # GCC 8 CXXFLAGS_WARNINGS += -Wcast-align=strict CFLAGS_WARNINGS += -Wcast-align=strict |
|
From: <sv...@op...> - 2025-02-15 15:48:16
|
Author: manx Date: Sat Feb 15 16:48:02 2025 New Revision: 22879 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22879 Log: [Fix] build: Makefile: GCC: Fix typo in linker option --no-undefined. [Fix] build: Makefile: Clang: Fix typo in linker option --no-undefined. Modified: trunk/OpenMPT/build/make/warnings-clang.mk trunk/OpenMPT/build/make/warnings-gcc.mk Modified: trunk/OpenMPT/build/make/warnings-clang.mk ============================================================================== --- trunk/OpenMPT/build/make/warnings-clang.mk Sat Feb 15 16:46:34 2025 (r22878) +++ trunk/OpenMPT/build/make/warnings-clang.mk Sat Feb 15 16:48:02 2025 (r22879) @@ -18,7 +18,7 @@ ifeq ($(MODERN),1) CXXFLAGS_WARNINGS += CFLAGS_WARNINGS += -LDFLAGS_WARNINGS += -Wl,-no-undefined +LDFLAGS_WARNINGS += -Wl,--no-undefined endif CFLAGS_SILENT += -Wno-\#warnings Modified: trunk/OpenMPT/build/make/warnings-gcc.mk ============================================================================== --- trunk/OpenMPT/build/make/warnings-gcc.mk Sat Feb 15 16:46:34 2025 (r22878) +++ trunk/OpenMPT/build/make/warnings-gcc.mk Sat Feb 15 16:48:02 2025 (r22879) @@ -11,7 +11,7 @@ #CXXFLAGS_WARNINGS += -Wshadow -Wswitch-enum CXXFLAGS_WARNINGS += -Wconversion # gold -LDFLAGS_WARNINGS += -Wl,-no-undefined -Wl,--detect-odr-violations +LDFLAGS_WARNINGS += -Wl,--no-undefined -Wl,--detect-odr-violations # GCC 8 CXXFLAGS_WARNINGS += -Wcast-align=strict CFLAGS_WARNINGS += -Wcast-align=strict |
|
From: <sv...@op...> - 2025-02-15 15:46:45
|
Author: manx Date: Sat Feb 15 16:46:34 2025 New Revision: 22878 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22878 Log: Merged revision(s) 22874 from trunk/OpenMPT: [Fix] stb_vorbis: Fix Clang -Wtautological-compare warning and related Undefined Behaviour. Apply <https://github.com/nothings/stb/pull/1746>. ........ Modified: branches/OpenMPT-1.28/ (props changed) branches/OpenMPT-1.28/include/stb_vorbis/OpenMPT.txt branches/OpenMPT-1.28/include/stb_vorbis/stb_vorbis.c Modified: branches/OpenMPT-1.28/include/stb_vorbis/OpenMPT.txt ============================================================================== --- branches/OpenMPT-1.28/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:46:11 2025 (r22877) +++ branches/OpenMPT-1.28/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:46:34 2025 (r22878) @@ -3,6 +3,7 @@ commit 5a0bb8b1c1b1ca3f4e2485f4114c1c8ea021b781 (2021-07-12) Modifications: + * <https://github.com/nothings/stb/pull/1746> has been applied. * Use of alloca has been replaced with malloc, as alloca is not in C99 and fails to compile. * Macro redefinition of alloca with mingw-w64 has been fixed. @@ -10,4 +11,3 @@ For building, premake is used to generate Visual Studio project files. See ../build/premake/ for details. - Modified: branches/OpenMPT-1.28/include/stb_vorbis/stb_vorbis.c ============================================================================== --- branches/OpenMPT-1.28/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:46:11 2025 (r22877) +++ branches/OpenMPT-1.28/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:46:34 2025 (r22878) @@ -1410,7 +1410,7 @@ #endif f->eof = 0; if (USE_MEMORY(f)) { - if (f->stream_start + loc >= f->stream_end || f->stream_start + loc < f->stream_start) { + if (loc >= f->stream_len) { f->stream = f->stream_end; f->eof = 1; return 0; |
|
From: <sv...@op...> - 2025-02-15 15:46:23
|
Author: manx Date: Sat Feb 15 16:46:11 2025 New Revision: 22877 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22877 Log: Merged revision(s) 22874 from trunk/OpenMPT: [Fix] stb_vorbis: Fix Clang -Wtautological-compare warning and related Undefined Behaviour. Apply <https://github.com/nothings/stb/pull/1746>. ........ Modified: branches/OpenMPT-1.29/ (props changed) branches/OpenMPT-1.29/include/stb_vorbis/OpenMPT.txt branches/OpenMPT-1.29/include/stb_vorbis/stb_vorbis.c Modified: branches/OpenMPT-1.29/include/stb_vorbis/OpenMPT.txt ============================================================================== --- branches/OpenMPT-1.29/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:45:42 2025 (r22876) +++ branches/OpenMPT-1.29/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:46:11 2025 (r22877) @@ -3,6 +3,7 @@ commit 5a0bb8b1c1b1ca3f4e2485f4114c1c8ea021b781 (2021-07-12) Modifications: + * <https://github.com/nothings/stb/pull/1746> has been applied. * Use of alloca has been replaced with malloc, as alloca is not in C99 and fails to compile. * Macro redefinition of alloca with mingw-w64 has been fixed. @@ -10,4 +11,3 @@ For building, premake is used to generate Visual Studio project files. See ../build/premake/ for details. - Modified: branches/OpenMPT-1.29/include/stb_vorbis/stb_vorbis.c ============================================================================== --- branches/OpenMPT-1.29/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:45:42 2025 (r22876) +++ branches/OpenMPT-1.29/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:46:11 2025 (r22877) @@ -1410,7 +1410,7 @@ #endif f->eof = 0; if (USE_MEMORY(f)) { - if (f->stream_start + loc >= f->stream_end || f->stream_start + loc < f->stream_start) { + if (loc >= f->stream_len) { f->stream = f->stream_end; f->eof = 1; return 0; |
|
From: <sv...@op...> - 2025-02-15 15:45:58
|
Author: manx Date: Sat Feb 15 16:45:42 2025 New Revision: 22876 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22876 Log: Merged revision(s) 22874 from trunk/OpenMPT: [Fix] stb_vorbis: Fix Clang -Wtautological-compare warning and related Undefined Behaviour. Apply <https://github.com/nothings/stb/pull/1746>. ........ Modified: branches/OpenMPT-1.30/ (props changed) branches/OpenMPT-1.30/include/stb_vorbis/OpenMPT.txt branches/OpenMPT-1.30/include/stb_vorbis/stb_vorbis.c Modified: branches/OpenMPT-1.30/include/stb_vorbis/OpenMPT.txt ============================================================================== --- branches/OpenMPT-1.30/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:45:00 2025 (r22875) +++ branches/OpenMPT-1.30/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:45:42 2025 (r22876) @@ -3,6 +3,7 @@ commit 5a0bb8b1c1b1ca3f4e2485f4114c1c8ea021b781 (2021-07-12) Modifications: + * <https://github.com/nothings/stb/pull/1746> has been applied. * Use of alloca has been replaced with malloc, as alloca is not in C99 and fails to compile. * Macro redefinition of alloca with mingw-w64 has been fixed. @@ -10,4 +11,3 @@ For building, premake is used to generate Visual Studio project files. See ../build/premake/ for details. - Modified: branches/OpenMPT-1.30/include/stb_vorbis/stb_vorbis.c ============================================================================== --- branches/OpenMPT-1.30/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:45:00 2025 (r22875) +++ branches/OpenMPT-1.30/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:45:42 2025 (r22876) @@ -1410,7 +1410,7 @@ #endif f->eof = 0; if (USE_MEMORY(f)) { - if (f->stream_start + loc >= f->stream_end || f->stream_start + loc < f->stream_start) { + if (loc >= f->stream_len) { f->stream = f->stream_end; f->eof = 1; return 0; |
|
From: <sv...@op...> - 2025-02-15 15:45:12
|
Author: manx Date: Sat Feb 15 16:45:00 2025 New Revision: 22875 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22875 Log: Merged revision(s) 22874 from trunk/OpenMPT: [Fix] stb_vorbis: Fix Clang -Wtautological-compare warning and related Undefined Behaviour. Apply <https://github.com/nothings/stb/pull/1746>. ........ Modified: branches/OpenMPT-1.31/ (props changed) branches/OpenMPT-1.31/include/stb_vorbis/OpenMPT.txt branches/OpenMPT-1.31/include/stb_vorbis/stb_vorbis.c Modified: branches/OpenMPT-1.31/include/stb_vorbis/OpenMPT.txt ============================================================================== --- branches/OpenMPT-1.31/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:43:10 2025 (r22874) +++ branches/OpenMPT-1.31/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:45:00 2025 (r22875) @@ -3,6 +3,7 @@ commit 5a0bb8b1c1b1ca3f4e2485f4114c1c8ea021b781 (2021-07-12) Modifications: + * <https://github.com/nothings/stb/pull/1746> has been applied. * Use of alloca has been replaced with malloc, as alloca is not in C99 and fails to compile. * Macro redefinition of alloca with mingw-w64 has been fixed. @@ -10,4 +11,3 @@ For building, premake is used to generate Visual Studio project files. See ../build/premake/ for details. - Modified: branches/OpenMPT-1.31/include/stb_vorbis/stb_vorbis.c ============================================================================== --- branches/OpenMPT-1.31/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:43:10 2025 (r22874) +++ branches/OpenMPT-1.31/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:45:00 2025 (r22875) @@ -1410,7 +1410,7 @@ #endif f->eof = 0; if (USE_MEMORY(f)) { - if (f->stream_start + loc >= f->stream_end || f->stream_start + loc < f->stream_start) { + if (loc >= f->stream_len) { f->stream = f->stream_end; f->eof = 1; return 0; |
|
From: <sv...@op...> - 2025-02-15 15:43:24
|
Author: manx Date: Sat Feb 15 16:43:10 2025 New Revision: 22874 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22874 Log: [Fix] stb_vorbis: Fix Clang -Wtautological-compare warning and related Undefined Behaviour. Apply <https://github.com/nothings/stb/pull/1746>. Modified: trunk/OpenMPT/include/stb_vorbis/OpenMPT.txt trunk/OpenMPT/include/stb_vorbis/stb_vorbis.c Modified: trunk/OpenMPT/include/stb_vorbis/OpenMPT.txt ============================================================================== --- trunk/OpenMPT/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:40:42 2025 (r22873) +++ trunk/OpenMPT/include/stb_vorbis/OpenMPT.txt Sat Feb 15 16:43:10 2025 (r22874) @@ -3,6 +3,7 @@ commit 5a0bb8b1c1b1ca3f4e2485f4114c1c8ea021b781 (2021-07-12) Modifications: + * <https://github.com/nothings/stb/pull/1746> has been applied. * Use of alloca has been replaced with malloc, as alloca is not in C99 and fails to compile. * Macro redefinition of alloca with mingw-w64 has been fixed. @@ -10,4 +11,3 @@ For building, premake is used to generate Visual Studio project files. See ../build/premake/ for details. - Modified: trunk/OpenMPT/include/stb_vorbis/stb_vorbis.c ============================================================================== --- trunk/OpenMPT/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:40:42 2025 (r22873) +++ trunk/OpenMPT/include/stb_vorbis/stb_vorbis.c Sat Feb 15 16:43:10 2025 (r22874) @@ -1410,7 +1410,7 @@ #endif f->eof = 0; if (USE_MEMORY(f)) { - if (f->stream_start + loc >= f->stream_end || f->stream_start + loc < f->stream_start) { + if (loc >= f->stream_len) { f->stream = f->stream_end; f->eof = 1; return 0; |
|
From: <sv...@op...> - 2025-02-15 15:40:54
|
Author: manx Date: Sat Feb 15 16:40:42 2025 New Revision: 22873 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22873 Log: [Mod] libopenmpt: Bump prerel version. Modified: trunk/OpenMPT/libopenmpt/libopenmpt_version.h trunk/OpenMPT/libopenmpt/libopenmpt_version.mk Modified: trunk/OpenMPT/libopenmpt/libopenmpt_version.h ============================================================================== --- trunk/OpenMPT/libopenmpt/libopenmpt_version.h Sat Feb 15 16:39:53 2025 (r22872) +++ trunk/OpenMPT/libopenmpt/libopenmpt_version.h Sat Feb 15 16:40:42 2025 (r22873) @@ -23,7 +23,7 @@ /*! \brief libopenmpt patch version number */ #define OPENMPT_API_VERSION_PATCH 0 /*! \brief libopenmpt pre-release tag */ -#define OPENMPT_API_VERSION_PREREL "-pre.12" +#define OPENMPT_API_VERSION_PREREL "-pre.13" /*! \brief libopenmpt pre-release flag */ #define OPENMPT_API_VERSION_IS_PREREL 1 Modified: trunk/OpenMPT/libopenmpt/libopenmpt_version.mk ============================================================================== --- trunk/OpenMPT/libopenmpt/libopenmpt_version.mk Sat Feb 15 16:39:53 2025 (r22872) +++ trunk/OpenMPT/libopenmpt/libopenmpt_version.mk Sat Feb 15 16:40:42 2025 (r22873) @@ -1,7 +1,7 @@ LIBOPENMPT_VERSION_MAJOR=0 LIBOPENMPT_VERSION_MINOR=8 LIBOPENMPT_VERSION_PATCH=0 -LIBOPENMPT_VERSION_PREREL=-pre.12 +LIBOPENMPT_VERSION_PREREL=-pre.13 LIBOPENMPT_LTVER_CURRENT=5 LIBOPENMPT_LTVER_REVISION=0 |
|
From: <sv...@op...> - 2025-02-15 15:40:01
|
Author: manx Date: Sat Feb 15 16:39:53 2025 New Revision: 22872 URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22872 Log: Revert r22848. It makes looping behaviour dependent on render settings (Channel layout, Gain, Stereo separation, Interpolation, Volume Ramping) without compensating for them, and dependent on live playback modification parameters (pitch, tempo, ...). Additionally it makes get_duration_seconds() even more wrong than it already was. It also breaks when scrubbing to the end of a song. It supposedly implements undocumented XMPlay functionality with arbitrary magic values. It is implemented at the wrong abstraction level (IFF we want to do something similar at all, it absolutely should be inside libopenmpt itself, and decided and queryable upfront in order to avoid the erratic behaviour). And, even without all that, such unpredictable behaviour must always be an explicit opt-in by both, client code, and the *informed* user anyway. Modified: trunk/OpenMPT/libopenmpt/xmp-openmpt/xmp-openmpt.cpp Modified: trunk/OpenMPT/libopenmpt/xmp-openmpt/xmp-openmpt.cpp ============================================================================== --- trunk/OpenMPT/libopenmpt/xmp-openmpt/xmp-openmpt.cpp Sun Feb 9 15:05:31 2025 (r22871) +++ trunk/OpenMPT/libopenmpt/xmp-openmpt/xmp-openmpt.cpp Sat Feb 15 16:39:53 2025 (r22872) @@ -150,19 +150,15 @@ struct self_xmplay_t { std::vector<double> subsong_lengths; - std::vector<float> last_audio_frames; std::vector<std::string> subsong_names; std::size_t samplerate = 48000; std::size_t num_channels = 2; - std::size_t last_audio_frames_write_pos = 0; xmp_openmpt_settings settings; openmpt::module_ext * mod = nullptr; bool set_format_called = false; openmpt::ext::pattern_vis * pattern_vis = nullptr; std::int32_t tempo_factor = 0, pitch_factor = 0; - std::int32_t subsong_start_order = 0, subsong_start_row = 0; bool single_subsong_mode = false; - bool end_of_song_reached = false; self_xmplay_t() { settings.changed = apply_and_save_options; } @@ -998,14 +994,8 @@ self->subsong_lengths = build_subsong_lengths( *self->mod ); self->subsong_names = self->mod->get_subsong_names(); self->mod->select_subsong( 0 ); - self->subsong_start_order = self->mod->get_current_order(); - self->subsong_start_row = self->mod->get_current_row(); self->tempo_factor = 0; self->pitch_factor = 0; - self->end_of_song_reached = false; - self->single_subsong_mode = false; - self->last_audio_frames.assign( self->last_audio_frames.size(), 0.0f ); - self->last_audio_frames_write_pos = 0; xmpfin->SetLength( static_cast<float>( self->subsong_lengths[0] ), TRUE ); return 2; @@ -1064,7 +1054,6 @@ } form->res = 4; // float form->chanmask = 0; - self->last_audio_frames.assign( self->samplerate / 500, 0.0f ); } // get the tags @@ -1187,29 +1176,13 @@ // In the auto-looping case, the function should only loop when a loop has been detected, and otherwise return -1 // If the time of the loop start position is known, that should be returned, otherwise -2 can be returned to let the time run on. // There is currently no way to easily figure out at which time the loop restarts. - self->end_of_song_reached = false; - if (self->mod->get_restart_order(self->mod->get_selected_subsong()) != self->subsong_start_order || self->mod->get_restart_row(self->mod->get_selected_subsong()) != self->subsong_start_row) { - return -2; - } else { - // Similar to XMPlay's auto-looping: If the last 2ms of audio are above -33dB RMS (roughly), we assume that the track is meant to loop. - float rms = 0.0f; - for ( const float v : self->last_audio_frames ) { - rms += v; // v is already squared - } - if ( std::sqrt( rms / self->last_audio_frames.size() ) >= 0.02f) - return -2; - else - return -1; // Let XMPlay's "auto-loop any track ending with sound" feature decide - } + return -2; } if ( pos & XMPIN_POS_SUBSONG ) { self->single_subsong_mode = ( pos & XMPIN_POS_SUBSONG1 ) != 0; - self->last_audio_frames.assign( self->last_audio_frames.size(), 0.0f ); const int32_t subsong = pos & 0xffff; try { self->mod->select_subsong( subsong ); - self->subsong_start_order = self->mod->get_current_order(); - self->subsong_start_row = self->mod->get_current_row(); } catch ( ... ) { return 0.0; } @@ -1220,7 +1193,6 @@ return 0.0; } double new_position = self->mod->set_position_seconds( static_cast<double>( pos ) * 0.001 ); - self->last_audio_frames.assign(self->last_audio_frames.size(), 0.0f); reset_timeinfos( new_position ); return new_position; } @@ -1239,57 +1211,39 @@ if ( !self->mod || self->num_channels == 0 ) { return 0; } - if (self->end_of_song_reached) { - self->end_of_song_reached = false; - return 0; - } update_timeinfos( self->samplerate, 0 ); std::size_t frames = count / self->num_channels; std::size_t frames_to_render = frames; std::size_t frames_rendered = 0; while ( frames_to_render > 0 ) { std::size_t frames_chunk = std::min( frames_to_render, static_cast<std::size_t>( ( self->samplerate + 99 ) / 100 ) ); // 100 Hz timing info update interval - std::size_t frames_read = 0; switch ( self->num_channels ) { case 1: { - frames_read = self->mod->read( self->samplerate, frames_chunk, dstbuf ); - for ( std::size_t i = 0; i < frames_read; i++ ) { - self->last_audio_frames[self->last_audio_frames_write_pos++] = dstbuf[i] * dstbuf[i]; - if ( self->last_audio_frames_write_pos >= self->last_audio_frames.size() ) - self->last_audio_frames_write_pos = 0; - } + frames_chunk = self->mod->read( self->samplerate, frames_chunk, dstbuf ); } break; case 2: { - frames_read = self->mod->read_interleaved_stereo( self->samplerate, frames_chunk, dstbuf ); - for ( std::size_t i = 0; i < frames_read * 2; i += 2 ) { - self->last_audio_frames[self->last_audio_frames_write_pos++] = (dstbuf[i] * dstbuf[i] + dstbuf[i + 1] * dstbuf[i + 1]) / 2; - if ( self->last_audio_frames_write_pos >= self->last_audio_frames.size() ) - self->last_audio_frames_write_pos = 0; - } + frames_chunk = self->mod->read_interleaved_stereo( self->samplerate, frames_chunk, dstbuf ); } break; case 4: { - frames_read = self->mod->read_interleaved_quad( self->samplerate, frames_chunk, dstbuf ); - for ( std::size_t i = 0; i < frames_read * 4; i += 4 ) { - self->last_audio_frames[self->last_audio_frames_write_pos++] = ( dstbuf[i] * dstbuf[i] + dstbuf[i + 1] * dstbuf[i + 1] + dstbuf[i + 2] * dstbuf[i + 2] + dstbuf[i + 3] * dstbuf[i + 3]) / 4; - if ( self->last_audio_frames_write_pos >= self->last_audio_frames.size() ) - self->last_audio_frames_write_pos = 0; - } + frames_chunk = self->mod->read_interleaved_quad( self->samplerate, frames_chunk, dstbuf ); } break; } - dstbuf += frames_read * self->num_channels; - update_timeinfos( self->samplerate, frames_read ); - frames_to_render -= frames_read; - frames_rendered += frames_read; - if ( frames_read < frames_chunk ) { - self->end_of_song_reached = true; + dstbuf += frames_chunk * self->num_channels; + if ( frames_chunk == 0 ) { break; } + update_timeinfos( self->samplerate, frames_chunk ); + frames_to_render -= frames_chunk; + frames_rendered += frames_chunk; + } + if ( frames_rendered == 0 ) { + return 0; } return frames_rendered * self->num_channels; } @@ -1738,7 +1692,7 @@ #endif static XMPIN xmpin = { - XMPIN_FLAG_CONFIG | XMPIN_FLAG_LOOP, // Add XMPIN_FLAG_LOOPSOUND to let XMPlay automatically determine whether the song should loop when returning -1 from openmpt_SetPosition + XMPIN_FLAG_CONFIG | XMPIN_FLAG_LOOP, xmp_openmpt_string, nullptr, // "libopenmpt\0mptm/mptmz", openmpt_About, @@ -1775,7 +1729,7 @@ openmpt_GetConfig, openmpt_SetConfig, - nullptr // Options + nullptr }; static const char * xmp_openmpt_default_exts = "OpenMPT\0mptm/mptmz"; |
3 messages has been excluded from this view by a project administrator.
