[OMPT-svn-commit] OpenMPT r23437 - in branches/OpenMPT-1.32: . openmpt123

[<sv...@op...>]

Author: manx
Date: Mon Jun  9 18:42:33 2025
New Revision: 23437
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=23437

Log:
Merged revision(s) 23435 from trunk/OpenMPT:
[Fix] openmpt123: Guard against libsndfile returning nullptr as file extension when matching the file format.
........

Modified:
   branches/OpenMPT-1.32/   (props changed)
   branches/OpenMPT-1.32/openmpt123/openmpt123_sndfile.hpp

Modified: branches/OpenMPT-1.32/openmpt123/openmpt123_sndfile.hpp
==============================================================================
--- branches/OpenMPT-1.32/openmpt123/openmpt123_sndfile.hpp	Mon Jun  9 18:42:04 2025	(r23436)
+++ branches/OpenMPT-1.32/openmpt123/openmpt123_sndfile.hpp	Mon Jun  9 18:42:33 2025	(r23437)
@@ -117,7 +117,7 @@
 					case match_recurse:
 						break;
 					case match_exact:
-						if ( mpt::transcode<std::string>( sndfile_encoding, extension ) == format_info.extension ) {
+						if ( format_info.extension && ( mpt::transcode<std::string>( sndfile_encoding, extension ) == format_info.extension ) ) {
 							if ( flags.use_float && ( subformat_info.format == SF_FORMAT_FLOAT ) ) {
 								return matched_result( format, format_info, subformat_info, match_mode );
 							} else if ( !flags.use_float && ( subformat_info.format == SF_FORMAT_PCM_16 ) ) {
@@ -126,7 +126,7 @@
 						}
 						break;
 					case match_better:
-						if ( mpt::transcode<std::string>( sndfile_encoding, extension ) == format_info.extension ) {
+						if ( format_info.extension && ( mpt::transcode<std::string>( sndfile_encoding, extension ) == format_info.extension ) ) {
 							if ( flags.use_float && ( subformat_info.format == SF_FORMAT_FLOAT || subformat_info.format == SF_FORMAT_DOUBLE ) ) {
 								return matched_result( format, format_info, subformat_info, match_mode );
 							} else if ( !flags.use_float && ( subformat_info.format & ( subformat_info.format == SF_FORMAT_PCM_16 || subformat_info.format == SF_FORMAT_PCM_24 || subformat_info.format == SF_FORMAT_PCM_32 ) ) ) {
@@ -135,7 +135,7 @@
 						}
 						break;
 					case match_any:
-						if ( mpt::transcode<std::string>( sndfile_encoding, extension ) == format_info.extension ) {
+						if ( format_info.extension && ( mpt::transcode<std::string>( sndfile_encoding, extension ) == format_info.extension ) ) {
 							return matched_result( format, format_info, subformat_info, match_mode );
 						}
 						break;