[OMPT-svn-commit] OpenMPT r23151 - in branches/OpenMPT-1.32: . soundlib

[<sv...@op...>]

Author: sagamusix
Date: Sat May  3 19:05:58 2025
New Revision: 23151
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=23151

Log:
Merged revision(s) 23150 from trunk/OpenMPT:
[Imp] Mod Conversion: When converting from XM, drop Offset commands that would not be doing anything.
........

Modified:
   branches/OpenMPT-1.32/   (props changed)
   branches/OpenMPT-1.32/soundlib/modcommand.cpp

Modified: branches/OpenMPT-1.32/soundlib/modcommand.cpp
==============================================================================
--- branches/OpenMPT-1.32/soundlib/modcommand.cpp	Sat May  3 19:05:37 2025	(r23150)
+++ branches/OpenMPT-1.32/soundlib/modcommand.cpp	Sat May  3 19:05:58 2025	(r23151)
@@ -926,6 +926,10 @@
 			command = CMD_XFINEPORTAUPDOWN;
 	}
 
+	// Offset effect memory is only updated when the command is placed next to a note.
+	if(oldTypeIsXM && command == CMD_OFFSET && !IsNote())
+		command = CMD_NONE;
+
 	if((command == CMD_REVERSEOFFSET || command == CMD_OFFSETPERCENTAGE) && !newSpecs.HasCommand(command))
 	{
 		command = CMD_OFFSET;