[OMPT-svn-commit] OpenMPT r22884 - trunk/OpenMPT/build/make

[<sv...@op...>]

Author: manx
Date: Sat Feb 15 16:59:56 2025
New Revision: 22884
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22884

Log:
[Imp] build: Makefile: Unconditionally set --no-undefined linker option. Without the typo, this should hopefully work on all supported platforms.

Modified:
   trunk/OpenMPT/build/make/warnings-clang.mk
   trunk/OpenMPT/build/make/warnings-gcc.mk

Modified: trunk/OpenMPT/build/make/warnings-clang.mk
==============================================================================
--- trunk/OpenMPT/build/make/warnings-clang.mk	Sat Feb 15 16:53:09 2025	(r22883)
+++ trunk/OpenMPT/build/make/warnings-clang.mk	Sat Feb 15 16:59:56 2025	(r22884)
@@ -15,10 +15,12 @@
 #CXXFLAGS_WARNINGS += -Wconversion
 #CXXFLAGS_WARNINGS += -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-c++98-c++11-c++14-compat -Wno-padded -Wno-weak-vtables -Wno-sign-conversion -Wno-shadow-field-in-constructor -Wno-conversion -Wno-switch-enum -Wno-old-style-cast
 
+LDFLAGS_WARNINGS  += -Wl,--no-undefined
+
 ifeq ($(MODERN),1)
 CXXFLAGS_WARNINGS += 
 CFLAGS_WARNINGS   += 
-LDFLAGS_WARNINGS  += -Wl,--no-undefined
+LDFLAGS_WARNINGS  += 
 endif
 
 CFLAGS_SILENT += -Wno-\#warnings

Modified: trunk/OpenMPT/build/make/warnings-gcc.mk
==============================================================================
--- trunk/OpenMPT/build/make/warnings-gcc.mk	Sat Feb 15 16:53:09 2025	(r22883)
+++ trunk/OpenMPT/build/make/warnings-gcc.mk	Sat Feb 15 16:59:56 2025	(r22884)
@@ -4,6 +4,8 @@
 
 CXXFLAGS_WARNINGS += -Wno-psabi
 
+LDFLAGS_WARNINGS  += -Wl,--no-undefined
+
 ifeq ($(MODERN),1)
 # GCC >= 12
 # -Wconversion is way too noisy for earlier GCC versions
@@ -11,7 +13,7 @@
 #CXXFLAGS_WARNINGS += -Wshadow -Wswitch-enum 
 CXXFLAGS_WARNINGS += -Wconversion
 # gold
-LDFLAGS_WARNINGS  += -Wl,--no-undefined -Wl,--detect-odr-violations
+LDFLAGS_WARNINGS  += -Wl,--detect-odr-violations
 # GCC 8
 CXXFLAGS_WARNINGS += -Wcast-align=strict
 CFLAGS_WARNINGS   += -Wcast-align=strict