[OMPT-svn-commit] OpenMPT r22460 - trunk/OpenMPT/mptrack

[<sv...@op...>]

Author: sagamusix
Date: Mon Dec  2 21:58:48 2024
New Revision: 22460
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22460

Log:
[Fix] Quick Start: If trying to open an MRU item from the File menu failed, subsequently trying to erase an MRU item through the Quick Start dialog caused the wrong MRU item to be removed.

Modified:
   trunk/OpenMPT/mptrack/QuickStartDialog.cpp

Modified: trunk/OpenMPT/mptrack/QuickStartDialog.cpp
==============================================================================
--- trunk/OpenMPT/mptrack/QuickStartDialog.cpp	Mon Dec  2 21:20:51 2024	(r22459)
+++ trunk/OpenMPT/mptrack/QuickStartDialog.cpp	Mon Dec  2 21:58:48 2024	(r22460)
@@ -229,8 +229,10 @@
 	{
 		if(GetItemGroup(i) != 0)
 			continue;
-		mruFiles.erase(mruFiles.begin() + i);
-		m_paths[0][GetItemIndex(i)] = {};
+		auto &path = m_paths[0][GetItemIndex(i)];
+		if(auto it = std::find(mruFiles.begin(), mruFiles.end(), path); it != mruFiles.end())
+			mruFiles.erase(it);
+		path = {};
 		m_list.DeleteItem(i);
 		i--;
 	}