[OMPT-svn-commit] OpenMPT r22231 - trunk/OpenMPT/soundlib/plugins/dmo

[<sv...@op...>]

Author: sagamusix
Date: Mon Nov 18 22:40:48 2024
New Revision: 22231
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22231

Log:
[FIx] I3DL2Reverb: Avoid undefined behaviour in integer overflows when calculating delay lines before their structures have been fully initialized.

Modified:
   trunk/OpenMPT/soundlib/plugins/dmo/I3DL2Reverb.h

Modified: trunk/OpenMPT/soundlib/plugins/dmo/I3DL2Reverb.h
==============================================================================
--- trunk/OpenMPT/soundlib/plugins/dmo/I3DL2Reverb.h	Mon Nov 18 22:35:52 2024	(r22230)
+++ trunk/OpenMPT/soundlib/plugins/dmo/I3DL2Reverb.h	Mon Nov 18 22:40:48 2024	(r22231)
@@ -50,9 +50,9 @@
 
 	class DelayLine : private std::vector<float>
 	{
-		int32 m_length;
-		int32 m_position;
-		int32 m_delayPosition;
+		int32 m_length = 0;
+		int32 m_position = 0;
+		int32 m_delayPosition = 0;
 
 	public:
 		void Init(int32 ms, int32 padding, uint32 sampleRate, int32 delayTap = 0);