[OMPT-svn-commit] OpenMPT r22227 - trunk/OpenMPT/soundlib

[<sv...@op...>]

Author: sagamusix
Date: Mon Nov 18 21:23:25 2024
New Revision: 22227
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22227

Log:
[Fix] MMCMP: Avoid undefined shift behaviour when trying to read an arbitrary number of bits. Reject such malformed files like Ancient does.

Modified:
   trunk/OpenMPT/soundlib/ContainerMMCMP.cpp

Modified: trunk/OpenMPT/soundlib/ContainerMMCMP.cpp
==============================================================================
--- trunk/OpenMPT/soundlib/ContainerMMCMP.cpp	Mon Nov 18 21:01:34 2024	(r22226)
+++ trunk/OpenMPT/soundlib/ContainerMMCMP.cpp	Mon Nov 18 21:23:25 2024	(r22227)
@@ -231,6 +231,7 @@
 #ifdef MMCMP_LOG
 			MPT_LOG_GLOBAL(LogDebug, "MMCMP", MPT_UFORMAT("  16-bit block: pos={} size={} {} {}")(psubblk->position, psubblk->size, (blk.flags & MMCMP_DELTA) ? U_("DELTA ") : U_(""), (blk.flags & MMCMP_ABS16) ? U_("ABS16 ") : U_("")));
 #endif
+			if(numbits > 15) return false;
 			if(!file.Seek(memPos + blk.tt_entries)) return false;
 			if(!file.CanRead(blk.pk_size - blk.tt_entries)) return false;
 			BitReader bitFile{ file.GetChunk(blk.pk_size - blk.tt_entries) };
@@ -316,6 +317,7 @@
 			uint32 numbits = blk.num_bits;
 			uint32 oldval = 0;
 			if(blk.tt_entries > sizeof(ptable)
+				|| numbits > 7
 				|| !file.Seek(memPos)
 				|| file.ReadRaw(mpt::span(ptable, blk.tt_entries)).size() < blk.tt_entries)
 				return false;