[OMPT-svn-commit] OpenMPT r22224 - trunk/OpenMPT/soundlib

[<sv...@op...>]

Author: sagamusix
Date: Mon Nov 18 20:19:48 2024
New Revision: 22224
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=22224

Log:
[Fix] Avoid extremely loud sample and synth amplification outside of supported GUI parameters. Found with afl++ + ubsan.

Modified:
   trunk/OpenMPT/soundlib/Load_it.cpp

Modified: trunk/OpenMPT/soundlib/Load_it.cpp
==============================================================================
--- trunk/OpenMPT/soundlib/Load_it.cpp	Mon Nov 18 19:52:52 2024	(r22223)
+++ trunk/OpenMPT/soundlib/Load_it.cpp	Mon Nov 18 20:19:48 2024	(r22224)
@@ -2664,12 +2664,9 @@
 		m_nMixLevels = MixLevels::Original;
 	//m_dwCreatedWithVersion
 	//m_dwLastSavedWithVersion
-	//m_nSamplePreAmp
-	//m_nVSTiVolume
-	//m_nDefaultGlobalVolume
+	LimitMax(m_nSamplePreAmp, 2000u);
+	LimitMax(m_nVSTiVolume, 2000u);
 	LimitMax(m_nDefaultGlobalVolume, MAX_GLOBAL_VOLUME);
-	//m_nRestartPos
-	//m_ModFlags
 	LimitMax(m_nDefaultRowsPerBeat, MAX_ROWS_PER_BEAT);
 	LimitMax(m_nDefaultRowsPerMeasure, MAX_ROWS_PER_BEAT);