[OMPT-svn-commit] OpenMPT r21561 - trunk/OpenMPT/src/mpt/random

[<sv...@op...>]

Author: manx
Date: Sun Sep  1 09:40:48 2024
New Revision: 21561
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=21561

Log:
[Ref] mpt/random/engine_lcg.hpp: Silence bogus MSVC static analyzer warning.

Modified:
   trunk/OpenMPT/src/mpt/random/engine_lcg.hpp

Modified: trunk/OpenMPT/src/mpt/random/engine_lcg.hpp
==============================================================================
--- trunk/OpenMPT/src/mpt/random/engine_lcg.hpp	Sat Aug 31 20:26:39 2024	(r21560)
+++ trunk/OpenMPT/src/mpt/random/engine_lcg.hpp	Sun Sep  1 09:40:48 2024	(r21561)
@@ -42,10 +42,10 @@
 		state_type result = 0;
 		std::array<unsigned int, mpt::align_up<std::size_t>(seed_bits, sizeof(unsigned int) * 8) / (sizeof(unsigned int) * 8)> seeds = {};
 		seed.generate(seeds.begin(), seeds.end());
-		for (std::size_t i = 0; i < mpt::align_up<std::size_t>(seed_bits, sizeof(unsigned int) * 8) / (sizeof(unsigned int) * 8); ++i) {
+		for (const auto & seed_value : seeds) {
 			result <<= 16;
 			result <<= 16;
-			result |= static_cast<state_type>(seeds[i]);
+			result |= static_cast<state_type>(seed_value);
 		}
 		return result;
 	}