[OMPT-svn-commit] OpenMPT r20848 - trunk/OpenMPT/soundlib

[<sv...@op...>]

Author: sagamusix
Date: Sat May 25 23:04:22 2024
New Revision: 20848
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=20848

Log:
[Fix] S3M: Don't update effect memory from cells without a command. This could happen after editing a pattern.

Modified:
   trunk/OpenMPT/soundlib/Snd_fx.cpp

Modified: trunk/OpenMPT/soundlib/Snd_fx.cpp
==============================================================================
--- trunk/OpenMPT/soundlib/Snd_fx.cpp	Sat May 25 17:51:23 2024	(r20847)
+++ trunk/OpenMPT/soundlib/Snd_fx.cpp	Sat May 25 23:04:22 2024	(r20848)
@@ -1000,7 +1000,7 @@
 				break;
 			}
 		
-			if(m_playBehaviour[kST3EffectMemory] && param != 0)
+			if(m_playBehaviour[kST3EffectMemory] && command != CMD_NONE && param != 0)
 			{
 				UpdateS3MEffectMemory(chn, param);
 			}
@@ -3614,7 +3614,7 @@
 			break;
 		}
 
-		if(m_playBehaviour[kST3EffectMemory] && param != 0)
+		if(m_playBehaviour[kST3EffectMemory] && cmd != CMD_NONE && param != 0)
 		{
 			UpdateS3MEffectMemory(chn, static_cast<ModCommand::PARAM>(param));
 		}