[OMPT-svn-commit] OpenMPT r20725 - trunk/OpenMPT/misc

[<sv...@op...>]

Author: manx
Date: Wed May  8 08:10:54 2024
New Revision: 20725
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=20725

Log:
[Fix] Static (internal linkage) functions in namespace scope in headers can cause ODR-violations when used by external linkage inline functions.

Modified:
   trunk/OpenMPT/misc/WriteMemoryDump.h

Modified: trunk/OpenMPT/misc/WriteMemoryDump.h
==============================================================================
--- trunk/OpenMPT/misc/WriteMemoryDump.h	Wed May  8 08:10:42 2024	(r20724)
+++ trunk/OpenMPT/misc/WriteMemoryDump.h	Wed May  8 08:10:54 2024	(r20725)
@@ -23,7 +23,7 @@
 
 OPENMPT_NAMESPACE_BEGIN
 
-static bool WriteMemoryDump(_EXCEPTION_POINTERS *pExceptionInfo, const TCHAR *filename, bool fullMemDump)
+inline bool WriteMemoryDump(_EXCEPTION_POINTERS *pExceptionInfo, const TCHAR *filename, bool fullMemDump)
 {
 	using MINIDUMPWRITEDUMP = BOOL(WINAPI *)(HANDLE hProcess, DWORD dwPid, HANDLE hFile, MINIDUMP_TYPE DumpType, CONST PMINIDUMP_EXCEPTION_INFORMATION ExceptionParam, CONST PMINIDUMP_USER_STREAM_INFORMATION UserStreamParam, CONST PMINIDUMP_CALLBACK_INFORMATION CallbackParam);