[OMPT-svn-commit] OpenMPT r20724 - trunk/OpenMPT/common

[<sv...@op...>]

Author: manx
Date: Wed May  8 08:10:42 2024
New Revision: 20724
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=20724

Log:
[Fix] Static (internal linkage) functions in namespace scope in headers can cause ODR-violations when used by external linkage inline functions.

Modified:
   trunk/OpenMPT/common/GzipWriter.h

Modified: trunk/OpenMPT/common/GzipWriter.h
==============================================================================
--- trunk/OpenMPT/common/GzipWriter.h	Tue May  7 23:59:00 2024	(r20723)
+++ trunk/OpenMPT/common/GzipWriter.h	Wed May  8 08:10:42 2024	(r20724)
@@ -22,7 +22,7 @@
 
 OPENMPT_NAMESPACE_BEGIN
 
-static void WriteGzip(std::ostream &output, std::string &outData, const mpt::ustring &fileName)
+inline void WriteGzip(std::ostream &output, std::string &outData, const mpt::ustring &fileName)
 {
 	z_stream strm{};
 	strm.avail_in = static_cast<uInt>(outData.size());