[OMPT-svn-commit] OpenMPT r20717 - trunk/OpenMPT/soundlib/plugins

[<sv...@op...>]

Author: sagamusix
Date: Mon May  6 22:48:35 2024
New Revision: 20717
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=20717

Log:
[Var] Check if removing the assert silences the newly-added cppcheck warning. Nothing in the code changes in r20712 should change anything about this logic, but since the entire class' inner workings require this pointer to be non-null, and it is the only place where it is check, maybe we can simply drop it...

Modified:
   trunk/OpenMPT/soundlib/plugins/PlugInterface.cpp

Modified: trunk/OpenMPT/soundlib/plugins/PlugInterface.cpp
==============================================================================
--- trunk/OpenMPT/soundlib/plugins/PlugInterface.cpp	Mon May  6 22:02:12 2024	(r20716)
+++ trunk/OpenMPT/soundlib/plugins/PlugInterface.cpp	Mon May  6 22:48:35 2024	(r20717)
@@ -241,8 +241,6 @@
 	//                 MIX_R += dryRatio * (WET_L - DRY_L) + wetRatio * (DRY_R - WET_R)
 	// -> mixop == 6:  same as normal, but forces dry ratio to 1
 
-	MPT_ASSERT(m_pMixStruct != nullptr);
-
 	const PluginMixMode mixop = m_pMixStruct->GetMixMode();
 
 	float wetRatio = 1.f - m_pMixStruct->fDryRatio;