[OMPT-svn-commit] OpenMPT r20668 - in branches/OpenMPT-1.31: . mptrack mptrack/plugins

[<sv...@op...>]

Author: sagamusix
Date: Sun Apr 28 15:42:30 2024
New Revision: 20668
URL: https://source.openmpt.org/browse/openmpt/?op=revision&rev=20668

Log:
Merged revision(s) 20667 from trunk/OpenMPT:
[Fix] Find/Replace: In the plugin parameter dropdown, parameter 999 was missing if the number of plugin parameters was unknown.
[Fix] When changing the output plugin from the LFO plugin's editor, the change was not reflected in the General tab.
........

Modified:
   branches/OpenMPT-1.31/   (props changed)
   branches/OpenMPT-1.31/mptrack/PatternFindReplaceDlg.cpp
   branches/OpenMPT-1.31/mptrack/plugins/LFOPluginEditor.cpp

Modified: branches/OpenMPT-1.31/mptrack/PatternFindReplaceDlg.cpp
==============================================================================
--- branches/OpenMPT-1.31/mptrack/PatternFindReplaceDlg.cpp	Sun Apr 28 15:42:13 2024	(r20667)
+++ branches/OpenMPT-1.31/mptrack/PatternFindReplaceDlg.cpp	Sun Apr 28 15:42:30 2024	(r20668)
@@ -510,8 +510,8 @@
 			AddPluginParameternamesToCombobox(m_cbnPCParam, *m_sndFile.m_MixPlugins[plug].pMixPlugin);
 		} else
 		{
-			m_cbnPCParam.InitStorage(ModCommand::maxColumnValue, 20);
-			for(int i = 0; i < ModCommand::maxColumnValue; i++)
+			m_cbnPCParam.InitStorage(ModCommand::maxColumnValue + 1, 20);
+			for(int i = 0; i < ModCommand::maxColumnValue + 1; i++)
 			{
 				wsprintf(s, _T("%02u: Parameter %02u"), static_cast<unsigned int>(i), static_cast<unsigned int>(i));
 				m_cbnPCParam.SetItemData(m_cbnPCParam.AddString(s), i);

Modified: branches/OpenMPT-1.31/mptrack/plugins/LFOPluginEditor.cpp
==============================================================================
--- branches/OpenMPT-1.31/mptrack/plugins/LFOPluginEditor.cpp	Sun Apr 28 15:42:13 2024	(r20667)
+++ branches/OpenMPT-1.31/mptrack/plugins/LFOPluginEditor.cpp	Sun Apr 28 15:42:30 2024	(r20668)
@@ -373,6 +373,8 @@
 			m_lfoPlugin.GetSoundFile().m_MixPlugins[m_lfoPlugin.GetSlot()].SetOutputPlugin(plug);
 			m_lfoPlugin.SetModified();
 			UpdateParamDisplays();
+			if(CModDoc *modDoc = m_lfoPlugin.GetSoundFile().GetpModDoc(); modDoc != nullptr)
+				modDoc->UpdateAllViews(nullptr, PluginHint(m_lfoPlugin.GetSlot() + 1).Info(), this);
 		}
 	}
 }