[OMPT-svn-commit] SF.net SVN: modplug:[2640] trunk/OpenMPT/mptrack

[<man...@us...>]

Revision: 2640
          http://sourceforge.net/p/modplug/code/2640
Author:   manxorist
Date:     2013-09-06 13:43:24 +0000 (Fri, 06 Sep 2013)
Log Message:
-----------
[Mod] Remove /debug command line option. It only activated a single line of logging in the DMO loading code, and only in debug builds. So it was basically useless.

Modified Paths:
--------------
    trunk/OpenMPT/mptrack/Mptrack.cpp
    trunk/OpenMPT/mptrack/Mptrack.h
    trunk/OpenMPT/mptrack/Vstplug.cpp

Modified: trunk/OpenMPT/mptrack/Mptrack.cpp
===================================================================
--- trunk/OpenMPT/mptrack/Mptrack.cpp	2013-09-06 12:05:47 UTC (rev 2639)
+++ trunk/OpenMPT/mptrack/Mptrack.cpp	2013-09-06 13:43:24 UTC (rev 2640)
@@ -269,14 +269,14 @@
 //================================================
 {
 public:
-	bool m_bNoAcm, m_bNoDls, m_bSafeMode, m_bNoPlugins, m_bDebug,
+	bool m_bNoAcm, m_bNoDls, m_bSafeMode, m_bNoPlugins,
 		 m_bPortable, m_bNoSettingsOnNewVersion;
 
 public:
 	CMPTCommandLineInfo()
 	{
 		m_bNoAcm = m_bNoDls = m_bSafeMode =
-		m_bNoPlugins = m_bDebug = m_bNoSettingsOnNewVersion = m_bPortable = false;
+		m_bNoPlugins = m_bNoSettingsOnNewVersion = m_bPortable = false;
 	}
 	virtual void ParseParam(LPCTSTR lpszParam, BOOL bFlag, BOOL bLast);
 };
@@ -291,7 +291,6 @@
 		if (!lstrcmpi(lpszParam, "nodls")) { m_bNoDls = true; return; } else
 		if (!lstrcmpi(lpszParam, "noacm")) { m_bNoAcm = true; return; } else
 		if (!lstrcmpi(lpszParam, "noplugs")) { m_bNoPlugins = true; return; } else
-		if (!lstrcmpi(lpszParam, "debug")) { m_bDebug = true; return; } else
 		if (!lstrcmpi(lpszParam, "portable")) { m_bPortable = true; return; } else
 		if (!lstrcmpi(lpszParam, "noSettingsOnNewVersion")) { m_bNoSettingsOnNewVersion = true; return; }
 	}
@@ -623,7 +622,6 @@
 	m_pModTemplate = NULL;
 	m_pPluginManager = NULL;
 	m_bInitialized = FALSE;
-	m_bDebugMode = FALSE;
 	m_szConfigFileName[0] = 0;
 }
 
@@ -856,8 +854,6 @@
 	{
 		StartSplashScreen();
 	}
-	m_bDebugMode = cmdInfo.m_bDebug;
-
 	// Enable drag/drop open
 	m_pMainWnd->DragAcceptFiles();
 

Modified: trunk/OpenMPT/mptrack/Mptrack.h
===================================================================
--- trunk/OpenMPT/mptrack/Mptrack.h	2013-09-06 12:05:47 UTC (rev 2639)
+++ trunk/OpenMPT/mptrack/Mptrack.h	2013-09-06 13:43:24 UTC (rev 2640)
@@ -111,7 +111,7 @@
 protected:
 	CMultiDocTemplate *m_pModTemplate;
 	CVstPluginManager *m_pPluginManager;
-	BOOL m_bInitialized, m_bDebugMode;
+	BOOL m_bInitialized;
 	DWORD m_dwTimeStarted, m_dwLastPluginIdleCall;
 	// Default macro configuration
 	MIDIMacroConfig m_MidiCfg;
@@ -157,7 +157,6 @@
 	CVstPluginManager *GetPluginManager() const { return m_pPluginManager; }
 	void GetDefaultMidiMacro(MIDIMacroConfig &cfg) const { cfg = m_MidiCfg; }
 	void SetDefaultMidiMacro(const MIDIMacroConfig &cfg) { m_MidiCfg = cfg; }
-	BOOL IsDebug() const { return m_bDebugMode; }
 	LPCTSTR GetConfigFileName() const { return m_szConfigFileName; }
 	bool IsPortableMode() { return m_bPortableMode; }
 	LPCTSTR GetPluginCacheFileName() const { return m_szPluginCacheFileName; }

Modified: trunk/OpenMPT/mptrack/Vstplug.cpp
===================================================================
--- trunk/OpenMPT/mptrack/Vstplug.cpp	2013-09-06 12:05:47 UTC (rev 2639)
+++ trunk/OpenMPT/mptrack/Vstplug.cpp	2013-09-06 13:43:24 UTC (rev 2640)
@@ -169,7 +169,7 @@
 						WideCharToMultiByte(CP_ACP, 0, w, -1, p->szDllPath, sizeof(p->szDllPath), nullptr, nullptr);
 						mpt::String::SetNullTerminator(p->szDllPath);
 					#ifdef DMO_LOG
-						if (theApp.IsDebug()) Log("Found \"%s\" clsid=%s\n", p->szLibraryName, p->szDllPath);
+						Log("Found \"%s\" clsid=%s\n", p->szLibraryName, p->szDllPath);
 					#endif
 						if (m_pVstHead) m_pVstHead->pPrev = p;
 						m_pVstHead = p;

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.