Re: [Modeling-users] ModelMasons refactored

[Mario R. <ma...@ru...>]

On mardi, avr 22, 2003, at 14:07 Europe/Amsterdam, Sebastien Bigaret=20
wrote:
>
> Mario Ruggier <ma...@ru...> writes:
>> Some minor comments, from tests here using the scripts:
>>
>> mdl_validate -v
>> - the -v switch is not listed in the usage info printed by the=20
>> script's -h
>
> Fixed on the cvs main trunk. I also changed a little the options: now
> '-w' discards warnings and info., and 'q' discards info. '-Q' is for
> *really* quiet.

OK.

>> mdl_generate_python_code.py -B
>> - it looks like second time generation does not overwrite anything in
>> the MDL directory. It should?
>
> I can't reproduce that, see e.g.:

Ooops, sorry my misreading of the log output ;-\

[snip]

>> - the switch --overwrite-existing-files seems to have disappeared, =
but
>> to me it still makes sense to keep the option if you want a clean
>> generation, and want to throw away the "working" files...
>
> I understand, however in that case I recommend moving or destroying =
the
> whole package or some files. I was forced to add this option earlier
> (but didn't like it) because it wasn't possible to say in a generation
> scheme which files should be overwritten; now that that's clear I=20
> prefer
> that the user handles this.

OK, fair enough.

>
>> mdl_generate_DB_schema.py
>> - when creating a table the first time around, all DROP statements=20
>> fail,
>> and execution stops unless the -i switch is used. Shouldn't DROP of
>> non-existant stuff not be treated like an error?
>
> Not sure what you mean here:
>
> $ mdl_generate_DB_schema.py -C -v \
>> --admin-dsn=3D"localhost:template1:postgres:" =
./model_StoreEmployees.xml
>
> does not try any drop statements. Could you be more precise on which
> situation(s) it annoys you?

mdl_generate_DB_schema.py -v -A model.xml

Sorry, I was just being too lazy, and wanted to execute the same command
whether it is the first time creating the table, or early interations=20
of the model
(requiring frequent regeneration). Hadn't "registered" the -C switch...


>>> BTW: Mario proposed that the generated class initializer could be:
>>>>   def __init__(self,att1=3DNone,att2=3DNone):
>>> instead of
>>>>   def __init__(self):
>>>
>>>   Are we ok we go for it?
>>
>> My vote is clear.
>
>   :)
>
> -- S=E9bastien.