Thread: Re: [Modcplusplus-devel] building an rpm package
Brought to you by:
gr84b8,
johnksterling
From: Pawel N. <ne...@fo...> - 2005-03-28 14:08:52
|
On Sat, 26 Mar 2005 09:19:28 -0500, John Sterling <jo...@st...> wrote : > By the way, mod_cplusplus 1.5.1 should have a fix for the shrext > problem. Also, I applied your other 2 patches - thanks. Great! I'm working on memory leaks right now. I found that there are dynamically allocated pointers stored in vectors, but there's no code that deletes them. Example: request_rec.cpp, but similar problems are in other files. I will send you a patch when I finish. I'm going to use smart pointers from boost (http://www.boost.org). -- **Pawel Niewiadomski**, new()foo-baz.com, http://new.foo-baz.com/ Virtual Qmail (http://v-q.foo-baz.com), qmail-patches (http://q-p.foo-baz.com) |
From: John S. <jo...@st...> - 2005-04-23 11:51:15
|
I Pawel - I'm just catching up on some patches. I'm thinking of redistributing the boost software as part of mod_cplusplus (i hate to have dependencies, makes it harder for peops to build the software). It appears they have a very flexible license, so I'm working on that. Just wanted to give you an update. John On Mar 28, 2005, at 9:08 AM, Pawel Niewiadomski wrote: > > On Sat, 26 Mar 2005 09:19:28 -0500, John Sterling <jo...@st...> > wrote : > >> By the way, mod_cplusplus 1.5.1 should have a fix for the shrext >> problem. Also, I applied your other 2 patches - thanks. > > Great! > I'm working on memory leaks right now. I found that there are > dynamically allocated pointers stored in vectors, but there's > no code that deletes them. Example: request_rec.cpp, but similar > problems are in other files. I will send you a patch when I finish. > I'm going to use smart pointers from boost (http://www.boost.org). > > -- > **Pawel Niewiadomski**, new()foo-baz.com, http://new.foo-baz.com/ > Virtual Qmail (http://v-q.foo-baz.com), qmail-patches > (http://q-p.foo-baz.com) > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real > users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > Modcplusplus-devel mailing list > Mod...@li... > https://lists.sourceforge.net/lists/listinfo/modcplusplus-devel > |
From: John S. <jo...@st...> - 2005-04-23 11:59:14
|
I'm having second thoughts about depending on boost like this. Seems like an unnecessary dependency. If there are memory leaks I can fix them by properly owning and cleaning up the objects. I like the other pieces of your patches, though. Is there any way you can remove the dependency but include some of your other fixes (e.g. apache 2.1 compilation fixes and win32 compilation fixes)? Thanks - John On Apr 23, 2005, at 7:50 AM, John Sterling wrote: > I Pawel - > > I'm just catching up on some patches. I'm thinking of redistributing > the boost software as part of mod_cplusplus (i hate to have > dependencies, makes it harder for peops to build the software). It > appears they have a very flexible license, so I'm working on that. > > Just wanted to give you an update. > > John > > On Mar 28, 2005, at 9:08 AM, Pawel Niewiadomski wrote: > >> >> On Sat, 26 Mar 2005 09:19:28 -0500, John Sterling <jo...@st...> >> wrote : >> >>> By the way, mod_cplusplus 1.5.1 should have a fix for the shrext >>> problem. Also, I applied your other 2 patches - thanks. >> >> Great! >> I'm working on memory leaks right now. I found that there are >> dynamically allocated pointers stored in vectors, but there's >> no code that deletes them. Example: request_rec.cpp, but similar >> problems are in other files. I will send you a patch when I finish. >> I'm going to use smart pointers from boost (http://www.boost.org). >> >> -- >> **Pawel Niewiadomski**, new()foo-baz.com, http://new.foo-baz.com/ >> Virtual Qmail (http://v-q.foo-baz.com), qmail-patches >> (http://q-p.foo-baz.com) >> >> >> >> ------------------------------------------------------- >> SF email is sponsored by - The IT Product Guide >> Read honest & candid reviews on hundreds of IT Products from real >> users. >> Discover which products truly live up to the hype. Start reading now. >> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click >> _______________________________________________ >> Modcplusplus-devel mailing list >> Mod...@li... >> https://lists.sourceforge.net/lists/listinfo/modcplusplus-devel >> > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real > users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > Modcplusplus-devel mailing list > Mod...@li... > https://lists.sourceforge.net/lists/listinfo/modcplusplus-devel > |