modcplusplus-devel

[Modcplusplus-devel] pRequest not check for NULL ?

[<jfa...@la...>]

in file apache_handler.cpp line 12. Is it done intentionaly ?

#define CALL_REQ_FUNCTION(function_name) \
     int result = DECLINED; \
     ApacheRequestRec *pRequest = new ApacheRequestRec(r); \
     cpp_config_rec *dir_rec = (cpp_config_rec *) \
         pRequest->get_dir_config(&cplusplus_module); \

Re: [Modcplusplus-devel] pRequest not check for NULL ?

[Jonathan W. <co...@co...>]

Jean-Fran?ois Adam wrote:

> in file apache_handler.cpp line 12. Is it done intentionaly ?
> 
> #define CALL_REQ_FUNCTION(function_name) \
>     int result = DECLINED; \
>     ApacheRequestRec *pRequest = new ApacheRequestRec(r); \
>     cpp_config_rec *dir_rec = (cpp_config_rec *) \
>         pRequest->get_dir_config(&cplusplus_module); \

I assume it's intentional, 'new' should not return NULL.

http://parashift.com/c++-faq-lite/freestore-mgmt.html#faq-16.6

jon

Re: [Modcplusplus-devel] pRequest not check for NULL ?

[<jfa...@la...>]

thanks for the reply. I haven't use c++ for a long time (and i =20
realize i've lost a lot of it!).

If it's not null and ApacheRequestRec has no virtual function,
I think it would be more natural to have the function call to pass a =20
reference of pRequest.
         } else { \
             result =3D handler->function_name(pRequest); \
         } \

IMHO i'd prefer to have a reference rather than a pointer to =20
ApacheRequestRec:
class MODCPP_API ApacheHandler : public ApacheBase
{
public:
     virtual int handler(ApacheRequestRec& r) { I can use r here;}
     virtual int handler(ApacheRequestRec* r) { is r 0 or not ? can i =20=

delete it ?;}
...
}

jfa


Le 31 juil. 05 =E0 13:03, Jonathan Wakely a =E9crit :

> Jean-Fran?ois Adam wrote:
>
>
>> in file apache_handler.cpp line 12. Is it done intentionaly ?
>>
>> #define CALL_REQ_FUNCTION(function_name) \
>>     int result =3D DECLINED; \
>>     ApacheRequestRec *pRequest =3D new ApacheRequestRec(r); \
>>     cpp_config_rec *dir_rec =3D (cpp_config_rec *) \
>>         pRequest->get_dir_config(&cplusplus_module); \
>>
>
> I assume it's intentional, 'new' should not return NULL.
>
> http://parashift.com/c++-faq-lite/freestore-mgmt.html#faq-16.6
>
> jon
>
>
>

Re: [Modcplusplus-devel] pRequest not check for NULL ?

[Jonathan W. <co...@co...>]

Jean-Fran?ois Adam wrote:

> thanks for the reply. I haven't use c++ for a long time (and i  
> realize i've lost a lot of it!).

Before C++ was standardised 'new' did return NULL, but it was changed
when exceptions were added to the language.

> If it's not null and ApacheRequestRec has no virtual function,
> I think it would be more natural to have the function call to pass a  
> reference of pRequest.

N.B. it makes no differencee whether ApacheRequestRec has virtual
functions, passing by reference still allows the class to behave
polymorphically.

I agree, in principle.  I have a few changes I would like to propose to
mod_cplusplus, but I wasn't going to suggest this, since it would be an
API change and would break existing code.  I prefer to use pointers
rather than references when you might want to pass NULL, but since that
doesn't apply here I see no reason to prefer a pointer to a reference
(except for backward-compatibility).

jon

-- 
"The future is here. It's just not evenly distributed yet."
	- William Gibson