Re: [mod-security-users] obsolete macros in running build.sh

[Ervin H. <ai...@gm...>]

Hi,

On Wed, Jan 31, 2024 at 03:17:38PM +0330, mahh m wrote:
> Hi,
> when I want to install modsecurity 3.0.12, by running build.sh these
> warnings are displayed: warning: The macro `AC_TRY_LINK' is obsolete.
> warning: The macro `AC_HEADER_STDC' is obsolete
> warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete
> warning: The macro `AC_TRY_COMPILE' is obsolete
> 
> the warnings remain after running "autoupdate".
> the version of "autoconf" is 2.71-2 (on ubuntu 22.04).

unfortunately there are few obsolote macros in m4 files. As the
most software, autotools is also constantly evolving, and this
brings that few macros will be obsolote.

Here is the full list for your version:

https://www.gnu.org/software/autoconf/manual/autoconf-2.71/html_node/Obsolete-Macros.html

> how can I resolve it?

If *YOU* want to resolve it, you should replace the old macro by
a new one. For eg. if you check the page above, there is a new
suggested version: AC_LINK_IFELSE.

So for eg. this patch solves the issue for AC_TRY_LINK:

diff --git a/build/pcre.m4 b/build/pcre.m4
index f338aa50..edac7c7e 100644
--- a/build/pcre.m4
+++ b/build/pcre.m4
@@ -77,10 +77,11 @@ else
         CFLAGS="${PCRE_CFLAGS} ${CFLAGS}"
         LDFLAGS="${PCRE_LDADD} ${LDFLAGS}"
         LIBS="${PCRE_LDADD} ${LIBS}"
-        AC_TRY_LINK([ #include <pcre.h> ],
-            [ pcre_jit_exec(NULL, NULL, NULL, 0, 0, 0, NULL, 0, NULL); ],
-            [ pcre_jit_available=yes ], [:]
-        )
+        AC_LINK_IFELSE(
+            [AC_LANG_PROGRAM([[ #include <pcre.h> ]],
+               [[ pcre_jit_exec(NULL, NULL, NULL, 0, 0, 0, NULL, 0, NULL); ]])],
+            [ pcre_jit_available=yes ],
+            [:])
 
         if test "x$pcre_jit_available" = "xyes"; then
             AC_MSG_RESULT(yes)

If you want to fix all of them, please send a PR here:

https://github.com/owasp-modsecurity/ModSecurity/pulls

If you don't want/can't cover this issue, please open an issue
here:

https://github.com/owasp-modsecurity/ModSecurity/issues/new?assignees=&labels=&projects=&template=bug-report-for-version-3-x.md&title=

and we try to solve that soon.



Thank you,



a.