|
From: Alberto G. I. <ag...@in...> - 2018-11-27 13:02:46
|
Hi Ervin! On Tue, Nov 27, 2018 at 12:21:28PM +0100, Ervin Hegedüs wrote: > Hi Alberto, > > On Tue, Nov 27, 2018 at 11:42:54AM +0100, Alberto Gonzalez Iniesta wrote: > > Hi, > > > > The build daemons at Debian are failing the test suite for modsecurity > > 3.x. There are two failures I could use some help on: > > > > 1) > > ./regression_tests .././test/test-cases/regression/variable-ENV.json:1 > > :test-result: FAIL variable-ENV.json:Testing Variables :: ENV (2/3) > > > > My guess is that build daemon don't have the TERM variable set, and I'm > > pondering disabling this test unless someone claims this is a bad idea. > > that's what I wrote you on mod-security-packagers list: > > https://sourceforge.net/p/mod-security/mailman/message/36455922/ > > But my question is: why is it better to completely disable the > test than my suggestion? As we already talked about, I'm not sure that playing with envvars in build daemons is such a good idea. And I'd like to know if that test is really useful. That's why I asked here again. > * I've suggested a solution: > https://github.com/airween/ModSecurity/blob/90a09f3a7616ae8f4406a30d213bd971cf1c45bb/debian/rules#L9 > * I'm sure that there are several other solution, eg: make a > patch in debian/patches/ directory, which replaces the TERM > variable for an another ENV variable, which exists in build > system? Maybe the person that created the test case in the first place can clarify the target of it. Regards, Alberto -- Alberto Gonzalez Iniesta | Formación, consultoría y soporte técnico mailto/sip: ag...@in... | en GNU/Linux y software libre Encrypted mail preferred | http://inittab.com Key fingerprint = 5347 CBD8 3E30 A9EB 4D7D 4BF2 009B 3375 6B9A AA55 |
