|
From: Ervin H. <ai...@gm...> - 2018-11-27 11:21:51
|
Hi Alberto, On Tue, Nov 27, 2018 at 11:42:54AM +0100, Alberto Gonzalez Iniesta wrote: > Hi, > > The build daemons at Debian are failing the test suite for modsecurity > 3.x. There are two failures I could use some help on: > > 1) > ./regression_tests .././test/test-cases/regression/variable-ENV.json:1 > :test-result: FAIL variable-ENV.json:Testing Variables :: ENV (2/3) > > My guess is that build daemon don't have the TERM variable set, and I'm > pondering disabling this test unless someone claims this is a bad idea. that's what I wrote you on mod-security-packagers list: https://sourceforge.net/p/mod-security/mailman/message/36455922/ But my question is: why is it better to completely disable the test than my suggestion? * I've suggested a solution: https://github.com/airween/ModSecurity/blob/90a09f3a7616ae8f4406a30d213bd971cf1c45bb/debian/rules#L9 * I'm sure that there are several other solution, eg: make a patch in debian/patches/ directory, which replaces the TERM variable for an another ENV variable, which exists in build system? > 2) But the ones that are really beyond my understanding are those in: > test/test-cases/secrules-language-tests/operators/ipMatch.json > Failing in s390, ppc64 and sparc64. I suspect they may be related to > endianness, but I really need help with those. You may find the build > logs here [1]. I'll check that soon. > If we get this solved quickly, modsecurity 3.x will be available in > Debian's next release. [2] please review the milestones: https://github.com/SpiderLabs/ModSecurity/milestones The next release had planned at Nov 08, 2019 - that's about a year. Hope that's just a "plan" :). But if the next release will not published till the freeze time, you have to make the patches. I'll help you readily. a. |
