In upcoming FreeBSD 14 is compiling bit more restrictive, so one warning before has become error now.
(cd /wrkdirs/usr/ports/www/mod_qos/work/mod_qos-11.73/apache2 && /usr/local/sbin/apxs -c -o mod_qos.la mod_qos.c) /usr/local/share/apr/build-1/libtool --silent --mode=compile cc -prefer-pic -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -I/usr/local/include/apache24 -I/usr/local/include/apr-1 -I/usr/local/include/apr-1 -I/usr/include -I/usr/local/include -I/usr/local/include/db18 -c -o mod_qos.lo mod_qos.c && touch mod_qos.slo mod_qos.c:1915:12: error: incompatible pointer to integer conversion assigning to 'unsigned int' from 'apr_os_thread_t' (aka 'struct pthread *') [-Wint-conversion] id.tid = apr_os_thread_current(); ^ ~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
Quick, but not beautiful fix for this is
--- mod_qos.c.orig 2023-03-07 20:42:41 UTC +++ mod_qos.c @@ -1912,7 +1912,7 @@ static const char *qos_unique_id(request_rec *r, const id.request_time = r->request_time; id.in_addr = m_unique_id.in_addr; #if APR_HAS_THREADS - id.tid = apr_os_thread_current(); + id.tid = (uintptr_t)apr_os_thread_current(); #else id.tid = 0; #endif
Thank you for your feedback. I've updated the source code to add the fix being part of the next release. https://sourceforge.net/p/mod-qos/source/2705/tree//trunk/httpd_src/modules/qos/mod_qos.c?diff=2691
Log in to post a comment.
In upcoming FreeBSD 14 is compiling bit more restrictive, so one warning before has become error now.
Quick, but not beautiful fix for this is
Thank you for your feedback.
I've updated the source code to add the fix being part of the next release.
https://sourceforge.net/p/mod-qos/source/2705/tree//trunk/httpd_src/modules/qos/mod_qos.c?diff=2691