Small improvements in directive declarations

[Rainer Jung]

Here are a ew small improvements in directuve declarations. Please double check, whether I am correct.

--- mod_qos.c     2022-03-18 12:31:05.130441100 +0100
+++ mod_qos.c   2022-03-19 13:39:59.695950800 +0100
@@ -14320,7 +14320,7 @@
 #else
   AP_INIT_TAKE2("QS_SrvMinDataRate", qos_min_rate_cmd, NULL,
                     RSRC_CONF,
-                    "QS_SrvMinDataRate <bytes per seconds> [<max bytes per second>],"
+                    "QS_SrvMinDataRate <bytes per seconds> <max bytes per second>,"
                     " defines the minimum upload/download"
                     " throughput a client must generate (the bytes send/received by the client"
                     " per seconds). This bandwidth is measured while transmitting the data"
@@ -14450,8 +14450,8 @@
   AP_INIT_TAKE1("QS_ResponseHeaderFilter", qos_resheaderfilter_cmd, NULL,
                 ACCESS_CONF,
                 "QS_ResponseHeaderFilter 'on'|'off', filters response headers by allowing"
-                " only these headers which match the request header rules defined by"
-                " mod_qos. Request headers which do not conform these definitions"
+                " only these headers which match the response header rules defined by"
+                " mod_qos. Response headers which do not conform these definitions"
                 " are dropped."),

 #ifdef AP_TAKE_ARGV
@@ -14589,12 +14589,14 @@
                  " omitted in order to simply set a new variable if"
                  " the regular expression matches."),

+#ifdef AP_TAKE_ARGV
   AP_INIT_TAKE_ARGV("QS_SetEnvIfCmp", qos_cmp_cmd, NULL,
                     ACCESS_CONF,
                     "QS_SetEnvIfCmpP <env-variable1> eq|ne|gt|lt <env-variable2> [!]<env-variable>[=<value>],"
                     " sets the specified environment variable if the specified env-variables"
                     " are alphabetically or numerical equal (eq), not equal (ne),"
                     " greater (gt), less (lt)."),
+#endif

   AP_INIT_TAKE2("QS_SetEnvIfQuery", qos_event_setenvifquery_cmd, NULL,
                 RSRC_CONF|ACCESS_CONF,
@@ -14691,13 +14693,13 @@

   AP_INIT_TAKE12("QS_SetEnvResHeader", qos_event_setenvresheader_cmd, NULL,
                  RSRC_CONF,
-                 "QS_SetEnvResHeader <header name> [drop], sets the defined"
+                 "QS_SetEnvResHeader <header name> [drop], copies the value of the defined"
                  " HTTP response header to the request environment variables."
                  " Deletes the header if the action 'drop' has been specified."),

   AP_INIT_TAKE2("QS_SetEnvResHeaderMatch", qos_event_setenvresheadermatch_cmd, NULL,
                 RSRC_CONF,
-                "QS_SetEnvResHeaderMatch <header name> <regex>, sets the defined"
+                "QS_SetEnvResHeaderMatch <header name> <regex>, copies the value of the defined"
                 " HTTP response header to the request environment variables"
                 " if the specified regular expression (pcre) matches the header value."),

For the first hunk: if the second argument is really optional, you might use AP_INIT_TAKE2 and adjust the function prototype of qos_min_rate_cmd.
In the second hunk the use of request instead of response two times IMHO is a copy and paste error.
In the third hunk I added "#ifdef AP_TAKE_ARGV" since you used this in all other places where AP_INIT_TAKE_ARGV directives are declared.
In the fourth/last hunk I think that "copy" makes more clear what happens, because mentionen the request env in a response directtive first sounds like a terminology mixup although it is correct.
Thanks and regards,
Rainer

[Rainer Jung]

I think this is still valid?

[Pascal Buchbinder]

Your feedback is greatly appreciated and was taken into account for the last release (even not 1:1).